Commit 1cb19180 authored by Bo Liu's avatar Bo Liu Committed by Chromium LUCI CQ

Test vulkan webview path

Before this, features::IsUsingVulkan is returning false on the Pie bot
because of the android version check in IsUsingVulkan. This ends up
causing testHardwareRenderingSmokeTestVulkanWhereSupported to use the
interop path instead of the real vulkan composite path.

Fix this by checking webview conditions before checking for android
version, and verified test is using vulkan composite now.

Bug: 1141687
Change-Id: Ida7e5ba778bdaf4cb04c00760598cf808647be46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644863Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846338}
parent 9fb38f59
...@@ -183,20 +183,21 @@ bool IsUsingVulkan() { ...@@ -183,20 +183,21 @@ bool IsUsingVulkan() {
features::kVulkan.name, base::FeatureList::OVERRIDE_ENABLE_FEATURE)) features::kVulkan.name, base::FeatureList::OVERRIDE_ENABLE_FEATURE))
return true; return true;
// WebView checks, which do not use (and disables) kVulkan.
// Do this above the Android version check because there are test devices
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kWebViewDrawFunctorUsesVulkan) &&
base::FeatureList::IsEnabled(kWebViewVulkan)) {
return true;
}
// No support for devices before Q -- exit before checking feature flags // No support for devices before Q -- exit before checking feature flags
// so that devices are not counted in finch trials. // so that devices are not counted in finch trials.
if (base::android::BuildInfo::GetInstance()->sdk_int() < if (base::android::BuildInfo::GetInstance()->sdk_int() <
base::android::SDK_VERSION_Q) base::android::SDK_VERSION_Q)
return false; return false;
// WebView defaults disables Vulkan in AwMainDelegate::BasicStartupComplete. return base::FeatureList::IsEnabled(kVulkan);
bool enable = base::FeatureList::IsEnabled(kVulkan);
// Check WebView support.
enable = enable || (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kWebViewDrawFunctorUsesVulkan) &&
base::FeatureList::IsEnabled(kWebViewVulkan));
return enable;
#else #else
return base::FeatureList::IsEnabled(kVulkan); return base::FeatureList::IsEnabled(kVulkan);
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment