Expand FindRightNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp

This patch expands |FindRightNonPseudoNodeInlineBox()| into the call site since
it is used once to reduce source code size for improving code health.

This patch is a follow-up of the patch[1].

The patch[2] does same thing for |FindLeftNonPseudoNodeInlineBox()|

[1] http://crrev.com/c/882791 LineEndpointComputationMode to template parameter
in StartPositionForLine()
[2] http://crrev.com/c/885683 Expand FindLeftNonPseudoNodeInlineBox() into the
call site in VisibleUnit.cpp

Change-Id: I57ae8c462a3b76ee07f41f3cabd6579765ee1a20
Reviewed-on: https://chromium-review.googlesource.com/885663
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531827}

third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

@@ -164,15 +164,6 @@ Node* NextLeafWithSameEditability(Node* node, EditableType editable_type) {
   return nullptr;
 }
 
-InlineBox* FindRightNonPseudoNodeInlineBox(const RootInlineBox& root_box) {
-  for (InlineBox* runner = root_box.FirstLeafChild(); runner;
-       runner = runner->NextLeafChild()) {
-    if (runner->GetLineLayoutItem().NonPseudoNode())
-      return runner;
-  }
-  return nullptr;
-}
-
 template <typename Strategy, typename Ordering>
 PositionWithAffinityTemplate<Strategy> StartPositionForLine(
     const PositionWithAffinityTemplate<Strategy>& c) {
@@ -237,10 +228,12 @@ struct VisualOrdering {
     // represented by a VisiblePosition. Use whatever follows instead.
     // TODO(editing-dev): We should consider text-direction of line to
     // find non-pseudo node.
-    InlineBox* const start_box = FindRightNonPseudoNodeInlineBox(root_box);
-    if (!start_box)
+    for (InlineBox* inline_box = root_box.FirstLeafChild(); inline_box;
+         inline_box = inline_box->NextLeafChild()) {
+      if (inline_box->GetLineLayoutItem().NonPseudoNode())
+        return {inline_box->GetLineLayoutItem().NonPseudoNode(), inline_box};
+    }
     return {nullptr, nullptr};
-    return {start_box->GetLineLayoutItem().NonPseudoNode(), start_box};
   }
 
   static std::pair<Node*, InlineBox*> EndNodeAndBoxOf(