Commit 1d2747c8 authored by Scott Violet's avatar Scott Violet Committed by Commit Bot

Gets ash_unittests --mash actually running tests again

Apparently a line like:

// foo

in the filter file results in all the other lines of the filter file
being ignored. This meant ash_unittests --mash on the bots wasn't
running any tests. Fixing the line shows a bunch of new tests are
failing. I've added them to the end and file a bug to recategorize
them.

I'll fix the bug in the filter file parsing separately.

BUG=813115
TEST=test only changes

Change-Id: If27f6e0738c4571c60e16bf87db6ba5cfac5cea3
Reviewed-on: https://chromium-review.googlesource.com/924270Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537352}
parent c0e80e68
...@@ -49,10 +49,29 @@ ...@@ -49,10 +49,29 @@
-DragWindowResizerTest.WindowDragWithMultiDisplaysRightToLeft -DragWindowResizerTest.WindowDragWithMultiDisplaysRightToLeft
# TODO: Extended desktop. http://crbug.com/695570 # TODO: Extended desktop. http://crbug.com/695570
-ExtendedDesktopTest.Activation
-ExtendedDesktopTest.Basic
-ExtendedDesktopTest.Capture
-ExtendedDesktopTest.CaptureEventLocation
-ExtendedDesktopTest.CaptureEventLocationHighDPI
-ExtendedDesktopTest.CaptureEventLocationHighDPI_2
-ExtendedDesktopTest.ConvertPoint
-ExtendedDesktopTest.GetRootWindowAt
-ExtendedDesktopTest.GetRootWindowMatching
-ExtendedDesktopTest.KeyEventsOnLockScreen -ExtendedDesktopTest.KeyEventsOnLockScreen
-ExtendedDesktopTest.MoveWindow
-ExtendedDesktopTest.MoveWindowByMouseClick
-ExtendedDesktopTest.MoveWindowToDisplay
-ExtendedDesktopTest.MoveWindowWithTransient
-ExtendedDesktopTest.OpenSystemTray
-ExtendedDesktopTest.PassiveGrab
-ExtendedDesktopTest.PostMoveParentTransientChild
-ExtendedDesktopTest.StayInSameRootWindow
-ExtendedDesktopTest.SystemModal
-ExtendedDesktopTest.TestCursor -ExtendedDesktopTest.TestCursor
-ExtendedDesktopTest.TestCursorLocation
// Test is flaky. http://crbug.com/794703. # Test is flaky. http://crbug.com/794703.
-HighlighterControllerTest.HighlighterGesturesScaled -HighlighterControllerTest.HighlighterGesturesScaled
# TODO: Top-of-screen mouse reveal doesn't work, maybe problem with # TODO: Top-of-screen mouse reveal doesn't work, maybe problem with
...@@ -244,4 +263,31 @@ ...@@ -244,4 +263,31 @@
# TODO: Needs CursorManager. http://crbug.com/631103 # TODO: Needs CursorManager. http://crbug.com/631103
-WorkspaceWindowResizerTest.MouseMoveWithTouchDrag -WorkspaceWindowResizerTest.MouseMoveWithTouchDrag
# TODO: these all crash/fail because we weren't running ash_unittests --mash
# for a period of time. The crashes need to be understood and more specific
# bugs filed. http://crbug.com/813115.
-DisplayManagerTest.CompositingCursorInMultiSoftwareMirroring
-DisplayManagerTestDisableMultiMirroring.SoftwareMirroringWithCompositingCursor
-DisplayManagerTest.SoftwareMirrorModeBasics
-DisplayManagerTest.UpdateMouseCursorAfterRotateZoom
-LockScreenSanityTest.PasswordSubmitClearsPasswordAfterFailedAuthentication
-LoginPasswordViewTest.SubmitButtonUpdatesUiState
-LoginShelfViewTest.TabGoesFromShelfToStatusAreaAndBackToShelf
-PartialMagnificationControllerTest.ActiveOnPointerDown
-PartialMagnificationControllerTest.DisablingDisablesActive
-PartialMagnificationControllerTest.MagnifierFollowsPointer
-PartialMagnificationControllerTest.MultipleDisplays
-RootWindowControllerTest.MoveWindows_Basic
-StatusAreaWidgetFocusTest.FocusOutObserver
-WindowManagerTest.ActivateOnMouse
-WindowManagerTest.ActivateOnPointerWindowProperty
-WindowManagerTest.ActivateOnTouch
-WindowManagerTest.AdditionalFilters
-WindowManagerTest.Focus
-WindowManagerTest.PanelActivation
-WindowManagerTest.TransformActivate
-WindowTreeHostManagerTest.DontUpdateInvisibleCursorLocationAfterDisplayChange
-WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange
-WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_2ndOnLeft
# Keep alphabetized. See comment at top of file. # Keep alphabetized. See comment at top of file.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment