Commit 1d7a9fa6 authored by Daniel Libby's avatar Daniel Libby Committed by Commit Bot

Remove compositing query in PaintLayer::PaintWithFilters

In pre-CAP code, if a filter is on a paint layer that has a
composited layer, it is determined to not paint with filters. In
which case, the filter is not taken into account for things like
computing the visual rect. However in the CAP world there is no
compositing state to consult so any PaintLayer that has filters
is considered to have paint with filters.

Bug: 1007989
Change-Id: Ibd5aae9a34f855a47fb863633bfe8d2319c3d08b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902727Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#714055}
parent 6c6af91e
...@@ -290,10 +290,14 @@ bool PaintLayer::PaintsWithFilters() const { ...@@ -290,10 +290,14 @@ bool PaintLayer::PaintsWithFilters() const {
if (!GetLayoutObject().HasFilterInducingProperty()) if (!GetLayoutObject().HasFilterInducingProperty())
return false; return false;
if (!RuntimeEnabledFeatures::CompositeAfterPaintEnabled()) {
// https://code.google.com/p/chromium/issues/detail?id=343759 // https://code.google.com/p/chromium/issues/detail?id=343759
DisableCompositingQueryAsserts disabler; DisableCompositingQueryAsserts disabler;
return !GetCompositedLayerMapping() || return !GetCompositedLayerMapping() ||
GetCompositingState() != kPaintsIntoOwnBacking; GetCompositingState() != kPaintsIntoOwnBacking;
} else {
return true;
}
} }
PhysicalOffset PaintLayer::SubpixelAccumulation() const { PhysicalOffset PaintLayer::SubpixelAccumulation() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment