Commit 1dc04bbe authored by treib's avatar treib Committed by Commit bot

Supervised users: Don't URLEscape extension update requests

Before, the colon in "extensionid:version" would get escaped, leading to
confusion all around

BUG=397951

Review URL: https://codereview.chromium.org/1033253002

Cr-Commit-Position: refs/heads/master@{#322576}
parent f0dd3f7e
...@@ -52,7 +52,7 @@ void PermissionRequestCreatorSync::CreateURLAccessRequest( ...@@ -52,7 +52,7 @@ void PermissionRequestCreatorSync::CreateURLAccessRequest(
const GURL& url_requested, const GURL& url_requested,
const SuccessCallback& callback) { const SuccessCallback& callback) {
CreateRequest(kSupervisedUserAccessRequestKeyPrefix, CreateRequest(kSupervisedUserAccessRequestKeyPrefix,
url_requested.spec(), net::EscapeQueryParamValue(url_requested.spec(), true),
callback); callback);
} }
...@@ -66,10 +66,9 @@ void PermissionRequestCreatorSync::CreateRequest( ...@@ -66,10 +66,9 @@ void PermissionRequestCreatorSync::CreateRequest(
const std::string& prefix, const std::string& prefix,
const std::string& data, const std::string& data,
const SuccessCallback& callback) { const SuccessCallback& callback) {
// Escape the data string and add the prefix. // Add the prefix.
std::string key = SupervisedUserSettingsService::MakeSplitSettingKey( std::string key =
prefix, SupervisedUserSettingsService::MakeSplitSettingKey(prefix, data);
net::EscapeQueryParamValue(data, true));
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue); scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
// TODO(sergiu): Use sane time here when it's ready. // TODO(sergiu): Use sane time here when it's ready.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment