Commit 1dc4fb27 authored by Xi Cheng's avatar Xi Cheng Committed by Commit Bot

Update comments on launching Chrome from native notifications with empty launch ids

Change-Id: I59fe94a572d24fef984cb6d1494d6e209217d8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1343497Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609528}
parent f09ec7a0
...@@ -99,13 +99,13 @@ HRESULT NotificationActivator::Activate( ...@@ -99,13 +99,13 @@ HRESULT NotificationActivator::Activate(
static_cast<int>(NotificationActivatorSecondaryStatus::kSuccess); static_cast<int>(NotificationActivatorSecondaryStatus::kSuccess);
// |invoked_args| contains the launch ID string encoded by Chrome. Chrome adds // |invoked_args| contains the launch ID string encoded by Chrome. Chrome adds
// it to the launch argument of the toast and gets it back via |invoked_args| // it to the launch argument of the toast and gets it back via |invoked_args|.
// here. Chrome needs the data to be able to look up the notification on its // Chrome needs the data to be able to look up the notification on its end.
// end.
// //
// TODO(chengx): When |invoked_args| is null or empty, there is no need to // When the user clicks the Chrome app title rather than the notifications in
// launch chrome. However, we still launch chrome for now to help investigate // the Action Center, an empty launch id string is generated. It is preferable
// issue 839942. // to launch Chrome with this empty launch id in this scenario, which results
// in displaying a NTP.
if (invoked_args == nullptr || invoked_args[0] == 0) { if (invoked_args == nullptr || invoked_args[0] == 0) {
secondary_status |= secondary_status |=
static_cast<int>(NotificationActivatorSecondaryStatus::kLaunchIdEmpty); static_cast<int>(NotificationActivatorSecondaryStatus::kLaunchIdEmpty);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment