Commit 1ecf5ec5 authored by dgozman@chromium.org's avatar dgozman@chromium.org

[DevTools] Fix integer/double values in emulation input fields.

BUG=none

Review URL: https://codereview.chromium.org/318653003

git-svn-id: svn://svn.chromium.org/blink/trunk@175484 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 3a05d72e
...@@ -441,16 +441,16 @@ WebInspector.ResponsiveDesignView.prototype = { ...@@ -441,16 +441,16 @@ WebInspector.ResponsiveDesignView.prototype = {
sectionElement.appendChild(fieldsetElement); sectionElement.appendChild(fieldsetElement);
fieldsetElement.createChild("div", "responsive-design-icon responsive-design-icon-resolution").title = WebInspector.UIString("Screen resolution"); fieldsetElement.createChild("div", "responsive-design-icon responsive-design-icon-resolution").title = WebInspector.UIString("Screen resolution");
fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "3em", WebInspector.OverridesSupport.inputValidator, true)); fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "3em", WebInspector.OverridesSupport.integerInputValidator, true));
fieldsetElement.appendChild(document.createTextNode(" \u00D7 ")); fieldsetElement.appendChild(document.createTextNode(" \u00D7 "));
fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", WebInspector.OverridesSupport.inputValidator, true)); fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", WebInspector.OverridesSupport.integerInputValidator, true));
this._swapDimensionsElement = fieldsetElement.createChild("button", "responsive-design-icon responsive-design-icon-swap"); this._swapDimensionsElement = fieldsetElement.createChild("button", "responsive-design-icon responsive-design-icon-swap");
this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions"); this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");
this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false); this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
fieldsetElement.createChild("div", "responsive-design-icon responsive-design-icon-dpr").title = WebInspector.UIString("Device pixel ratio"); fieldsetElement.createChild("div", "responsive-design-icon responsive-design-icon-dpr").title = WebInspector.UIString("Device pixel ratio");
fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 2, "2em", WebInspector.OverridesSupport.inputValidator, true)); fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, "2.5em", WebInspector.OverridesSupport.doubleInputValidator, true));
// Touch and viewport // Touch and viewport
sectionElement = this._toolbarElement.createChild("div", "responsive-design-section"); sectionElement = this._toolbarElement.createChild("div", "responsive-design-section");
......
...@@ -264,14 +264,14 @@ WebInspector.OverridesView.ViewportTab.prototype = { ...@@ -264,14 +264,14 @@ WebInspector.OverridesView.ViewportTab.prototype = {
cellElement.appendChild(document.createTextNode(WebInspector.UIString("Resolution:"))); cellElement.appendChild(document.createTextNode(WebInspector.UIString("Resolution:")));
cellElement = rowElement.createChild("td"); cellElement = rowElement.createChild("td");
var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebInspector.OverridesSupport.inputValidator, true); var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebInspector.OverridesSupport.integerInputValidator, true);
cellElement.appendChild(widthOverrideInput); cellElement.appendChild(widthOverrideInput);
this._swapDimensionsElement = cellElement.createChild("button", "overrides-swap"); this._swapDimensionsElement = cellElement.createChild("button", "overrides-swap");
this._swapDimensionsElement.appendChild(document.createTextNode(" \u21C4 ")); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW. this._swapDimensionsElement.appendChild(document.createTextNode(" \u21C4 ")); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW.
this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions"); this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");
this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false); this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
this._swapDimensionsElement.tabIndex = -1; this._swapDimensionsElement.tabIndex = -1;
var heightOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebInspector.OverridesSupport.inputValidator, true); var heightOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebInspector.OverridesSupport.integerInputValidator, true);
cellElement.appendChild(heightOverrideInput); cellElement.appendChild(heightOverrideInput);
rowElement = tableElement.createChild("tr"); rowElement = tableElement.createChild("tr");
...@@ -287,7 +287,7 @@ WebInspector.OverridesView.ViewportTab.prototype = { ...@@ -287,7 +287,7 @@ WebInspector.OverridesView.ViewportTab.prototype = {
rowElement = tableElement.createChild("tr"); rowElement = tableElement.createChild("tr");
rowElement.title = WebInspector.UIString("Ratio between a device's physical pixels and device-independent pixels."); rowElement.title = WebInspector.UIString("Ratio between a device's physical pixels and device-independent pixels.");
rowElement.createChild("td").appendChild(document.createTextNode(WebInspector.UIString("Device pixel ratio:"))); rowElement.createChild("td").appendChild(document.createTextNode(WebInspector.UIString("Device pixel ratio:")));
rowElement.createChild("td").appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 2, "80px", WebInspector.OverridesSupport.inputValidator, true)); rowElement.createChild("td").appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, "80px", WebInspector.OverridesSupport.doubleInputValidator, true));
var textAutosizingOverrideElement = this._createSettingCheckbox(WebInspector.UIString("Enable text autosizing "), WebInspector.overridesSupport.settings.deviceTextAutosizing); var textAutosizingOverrideElement = this._createSettingCheckbox(WebInspector.UIString("Enable text autosizing "), WebInspector.overridesSupport.settings.deviceTextAutosizing);
textAutosizingOverrideElement.title = WebInspector.UIString("Text autosizing is the feature that boosts font sizes on mobile devices."); textAutosizingOverrideElement.title = WebInspector.UIString("Text autosizing is the feature that boosts font sizes on mobile devices.");
......
...@@ -260,13 +260,23 @@ WebInspector.OverridesSupport.DeviceOrientation.clearDeviceOrientationOverride = ...@@ -260,13 +260,23 @@ WebInspector.OverridesSupport.DeviceOrientation.clearDeviceOrientationOverride =
/** /**
* @param {string} value * @param {string} value
*/ */
WebInspector.OverridesSupport.inputValidator = function(value) WebInspector.OverridesSupport.integerInputValidator = function(value)
{ {
if (value >= 0 && value <= 10000) if (/^[\d]+$/.test(value) && value >= 0 && value <= 10000)
return ""; return "";
return WebInspector.UIString("Value must be non-negative integer"); return WebInspector.UIString("Value must be non-negative integer");
} }
/**
* @param {string} value
*/
WebInspector.OverridesSupport.doubleInputValidator = function(value)
{
if (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 && value <= 10000)
return "";
return WebInspector.UIString("Value must be non-negative float");
}
// Third element lists device metrics separated by 'x': // Third element lists device metrics separated by 'x':
// - screen width, // - screen width,
// - screen height, // - screen height,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment