Commit 1f0fb469 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Chromium LUCI CQ

Put more VLOGs to investigate beacon behaviors on shutdown

Bug: 1161996
Change-Id: Iedc79e57787ef9e9c300bd8b9696353a28ba138e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643892Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846145}
parent 2589c8ce
...@@ -635,6 +635,10 @@ void RenderViewHostImpl::DispatchRenderViewCreated() { ...@@ -635,6 +635,10 @@ void RenderViewHostImpl::DispatchRenderViewCreated() {
} }
void RenderViewHostImpl::ClosePage() { void RenderViewHostImpl::ClosePage() {
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "RenderViewHostImpl::ClosePage() IsRenderViewLive() = "
<< IsRenderViewLive()
<< ", SuddenTerminationAllowed() = " << SuddenTerminationAllowed();
is_waiting_for_page_close_completion_ = true; is_waiting_for_page_close_completion_ = true;
if (IsRenderViewLive() && !SuddenTerminationAllowed()) { if (IsRenderViewLive() && !SuddenTerminationAllowed()) {
......
...@@ -4042,6 +4042,9 @@ bool Document::DispatchBeforeUnloadEvent(ChromeClient* chrome_client, ...@@ -4042,6 +4042,9 @@ bool Document::DispatchBeforeUnloadEvent(ChromeClient* chrome_client,
void Document::DispatchUnloadEvents( void Document::DispatchUnloadEvents(
SecurityOrigin* committing_origin, SecurityOrigin* committing_origin,
base::Optional<Document::UnloadEventTiming>* unload_timing) { base::Optional<Document::UnloadEventTiming>* unload_timing) {
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "Document::DispatchUnloadEvents() URL = " << Url();
PluginScriptForbiddenScope forbid_plugin_destructor_scripting; PluginScriptForbiddenScope forbid_plugin_destructor_scripting;
PageDismissalScope in_page_dismissal; PageDismissalScope in_page_dismissal;
if (parser_) if (parser_)
...@@ -4117,6 +4120,9 @@ void Document::DispatchUnloadEvents( ...@@ -4117,6 +4120,9 @@ void Document::DispatchUnloadEvents(
GetFrame()->Loader().SaveScrollAnchor(); GetFrame()->Loader().SaveScrollAnchor();
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "Actually dispatching an UnloadEvent: URL = " << Url();
load_event_progress_ = kUnloadEventInProgress; load_event_progress_ = kUnloadEventInProgress;
Event& unload_event = *Event::Create(event_type_names::kUnload); Event& unload_event = *Event::Create(event_type_names::kUnload);
const base::TimeTicks unload_event_start = base::TimeTicks::Now(); const base::TimeTicks unload_event_start = base::TimeTicks::Now();
......
...@@ -2636,6 +2636,9 @@ void LocalFrame::ClosePage( ...@@ -2636,6 +2636,9 @@ void LocalFrame::ClosePage(
mojom::blink::LocalMainFrame::ClosePageCallback completion_callback) { mojom::blink::LocalMainFrame::ClosePageCallback completion_callback) {
SECURITY_CHECK(IsMainFrame()); SECURITY_CHECK(IsMainFrame());
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "LocalFrame::ClosePage() URL = " << GetDocument()->Url();
// There are two ways to close a page: // There are two ways to close a page:
// //
// 1/ Via webview()->Close() that currently sets the WebView's delegate_ to // 1/ Via webview()->Close() that currently sets the WebView's delegate_ to
......
...@@ -80,9 +80,16 @@ bool NavigatorBeacon::SendBeaconImpl( ...@@ -80,9 +80,16 @@ bool NavigatorBeacon::SendBeaconImpl(
ExceptionState& exception_state) { ExceptionState& exception_state) {
ExecutionContext* context = ExecutionContext::From(script_state); ExecutionContext* context = ExecutionContext::From(script_state);
KURL url = context->CompleteURL(urlstring); KURL url = context->CompleteURL(urlstring);
if (!CanSendBeacon(context, url, exception_state)) if (!CanSendBeacon(context, url, exception_state)) {
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "Cannot send a beacon to " << url.ElidedString()
<< ", initiator = " << context->Url();
return false; return false;
}
// TODO(crbug.com/1161996): Remove this VLOG once the investigation is done.
VLOG(1) << "Send a beacon to " << url.ElidedString()
<< ", initiator = " << context->Url();
bool allowed; bool allowed;
LocalFrame* frame = GetSupplementable()->DomWindow()->GetFrame(); LocalFrame* frame = GetSupplementable()->DomWindow()->GetFrame();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment