Commit 1f4a7713 authored by stkhapugin@chromium.org's avatar stkhapugin@chromium.org Committed by Commit Bot

Enable Location Bar flag by default.

Enables the UI Refresh location bar flag by default. Fixes a test
that was attempting to tap the location view twice.

Bug: 821821
Tbr: noyau@chromium.org
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I02ad0dfbc98d86183b1a3628e2195b28e8993cd6
Reviewed-on: https://chromium-review.googlesource.com/1090929
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Reviewed-by: default avatarEric Noyau <noyau@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566774}
parent 862c2db3
...@@ -168,8 +168,7 @@ using chrome_test_util::SystemSelectionCalloutCopyButton; ...@@ -168,8 +168,7 @@ using chrome_test_util::SystemSelectionCalloutCopyButton;
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()] [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())]; assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()] [ChromeEarlGreyUI focusOmniboxAndType:@"foo"];
performAction:grey_typeText(@"foo")];
id<GREYMatcher> typingShield = grey_accessibilityID(@"Typing Shield"); id<GREYMatcher> typingShield = grey_accessibilityID(@"Typing Shield");
[[EarlGrey selectElementWithMatcher:typingShield] performAction:grey_tap()]; [[EarlGrey selectElementWithMatcher:typingShield] performAction:grey_tap()];
...@@ -431,11 +430,6 @@ using chrome_test_util::SystemSelectionCalloutCopyButton; ...@@ -431,11 +430,6 @@ using chrome_test_util::SystemSelectionCalloutCopyButton;
EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to a typing bug."); EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to a typing bug.");
} }
[ChromeEarlGrey loadURL:GURL("chrome://version")]; [ChromeEarlGrey loadURL:GURL("chrome://version")];
if (IsRefreshLocationBarEnabled()) {
[[EarlGrey
selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
}
[ChromeEarlGreyUI focusOmniboxAndType:@"javascript:alert('Hello');\n"]; [ChromeEarlGreyUI focusOmniboxAndType:@"javascript:alert('Hello');\n"];
[[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"Hello")] [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"Hello")]
......
...@@ -8,7 +8,7 @@ const base::Feature kRefreshPopupPresentation{ ...@@ -8,7 +8,7 @@ const base::Feature kRefreshPopupPresentation{
"UIRefreshPopupPresentation", base::FEATURE_DISABLED_BY_DEFAULT}; "UIRefreshPopupPresentation", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kUIRefreshLocationBar{"UIRefreshLocationBar", const base::Feature kUIRefreshLocationBar{"UIRefreshLocationBar",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kUIRefreshPhase1{"UIRefreshPhase1", const base::Feature kUIRefreshPhase1{"UIRefreshPhase1",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment