Commit 202eb7f8 authored by Yoichi Osato's avatar Yoichi Osato Committed by Commit Bot

DCHECK marker end offset in DocumentMarkerController.

This patch introduces a DCHECK checking if DocumentMarker.endoffset is
not over text length when adding each marker.

Bug: 868229
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4f2681460d1de1aacf78b55d7bba454dfc557cf2
Reviewed-on: https://chromium-review.googlesource.com/1149763
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579307}
parent 9ce7d0c3
...@@ -271,6 +271,7 @@ void DocumentMarkerController::AddMarkerInternal( ...@@ -271,6 +271,7 @@ void DocumentMarkerController::AddMarkerInternal(
void DocumentMarkerController::AddMarkerToNode(const Node& node, void DocumentMarkerController::AddMarkerToNode(const Node& node,
DocumentMarker* new_marker) { DocumentMarker* new_marker) {
DCHECK_GE(ToText(node).length(), new_marker->EndOffset());
possibly_existing_marker_types_ = possibly_existing_marker_types_.Add( possibly_existing_marker_types_ = possibly_existing_marker_types_.Add(
DocumentMarker::MarkerTypes(new_marker->GetType())); DocumentMarker::MarkerTypes(new_marker->GetType()));
SetContext(document_); SetContext(document_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment