Commit 20aefc94 authored by Gang Wu's avatar Gang Wu Committed by Commit Bot

[Feed] Implement logging API skeleton

Implement logging API skeleton

Bug:831638

Change-Id: I3b4d1f520fe0073bb81bbebc77765c3c76409cbd
Reviewed-on: https://chromium-review.googlesource.com/1160591Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580295}
parent 88fc70e6
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package org.chromium.chrome.browser.feed;
import com.google.android.libraries.feed.host.logging.BasicLoggingApi;
import com.google.android.libraries.feed.host.logging.ContentLoggingData;
/**
* Implementation of {@link BasicLoggingApi} that log actions performed on the Feed.
*/
public class FeedBasicLogging implements BasicLoggingApi {
// TODO(gangwu): implement BasicLoggingApi functionality.
@Override
public void onContentViewed(ContentLoggingData data) {}
@Override
public void onContentDismissed(ContentLoggingData data) {}
@Override
public void onContentClicked(ContentLoggingData data) {}
@Override
public void onContentContextMenuOpened(ContentLoggingData data) {}
@Override
public void onMoreButtonViewed(int position) {}
@Override
public void onMoreButtonClicked(int position) {}
@Override
public void onOpenedWithContent(int timeToPopulateMs, int contentCount) {}
@Override
public void onOpenedWithNoImmediateContent() {}
@Override
public void onOpenedWithNoContent() {}
}
...@@ -17,8 +17,6 @@ import com.google.android.libraries.feed.api.scope.FeedProcessScope; ...@@ -17,8 +17,6 @@ import com.google.android.libraries.feed.api.scope.FeedProcessScope;
import com.google.android.libraries.feed.api.scope.FeedStreamScope; import com.google.android.libraries.feed.api.scope.FeedStreamScope;
import com.google.android.libraries.feed.api.stream.Stream; import com.google.android.libraries.feed.api.stream.Stream;
import com.google.android.libraries.feed.host.action.ActionApi; import com.google.android.libraries.feed.host.action.ActionApi;
import com.google.android.libraries.feed.host.logging.BasicLoggingApi;
import com.google.android.libraries.feed.host.logging.ContentLoggingData;
import com.google.android.libraries.feed.host.stream.CardConfiguration; import com.google.android.libraries.feed.host.stream.CardConfiguration;
import com.google.android.libraries.feed.host.stream.SnackbarApi; import com.google.android.libraries.feed.host.stream.SnackbarApi;
import com.google.android.libraries.feed.host.stream.StreamConfiguration; import com.google.android.libraries.feed.host.stream.StreamConfiguration;
...@@ -58,28 +56,6 @@ public class FeedNewTabPage extends NewTabPage implements TouchEnabledDelegate { ...@@ -58,28 +56,6 @@ public class FeedNewTabPage extends NewTabPage implements TouchEnabledDelegate {
private SectionHeaderView mSectionHeaderView; private SectionHeaderView mSectionHeaderView;
private FeedImageLoader mImageLoader; private FeedImageLoader mImageLoader;
private static class DummyBasicLoggingApi implements BasicLoggingApi {
// TODO(gangwu): implement implement BasicLoggingApi functionality.
@Override
public void onContentViewed(ContentLoggingData data) {}
@Override
public void onContentDismissed(ContentLoggingData data) {}
@Override
public void onContentClicked(ContentLoggingData data) {}
@Override
public void onContentContextMenuOpened(ContentLoggingData data) {}
@Override
public void onMoreButtonViewed(int position) {}
@Override
public void onMoreButtonClicked(int position) {}
@Override
public void onOpenedWithContent(int timeToPopulateMs, int contentCount) {}
@Override
public void onOpenedWithNoImmediateContent() {}
@Override
public void onOpenedWithNoContent() {}
}
private class BasicSnackbarApi implements SnackbarApi { private class BasicSnackbarApi implements SnackbarApi {
@Override @Override
public void show(String message) { public void show(String message) {
...@@ -186,7 +162,7 @@ public class FeedNewTabPage extends NewTabPage implements TouchEnabledDelegate { ...@@ -186,7 +162,7 @@ public class FeedNewTabPage extends NewTabPage implements TouchEnabledDelegate {
.createFeedStreamScopeBuilder(activity, mImageLoader, actionApi, .createFeedStreamScopeBuilder(activity, mImageLoader, actionApi,
new BasicStreamConfiguration(activity.getResources()), new BasicStreamConfiguration(activity.getResources()),
new BasicCardConfiguration(activity.getResources()), new BasicCardConfiguration(activity.getResources()),
new BasicSnackbarApi(), new DummyBasicLoggingApi()) new BasicSnackbarApi(), new FeedBasicLogging())
.build(); .build();
mStream = streamScope.getStream(); mStream = streamScope.getStream();
......
...@@ -9,6 +9,7 @@ if (enable_feed_in_chrome) { ...@@ -9,6 +9,7 @@ if (enable_feed_in_chrome) {
feed_deps = [ "//third_party/feed:feed_lib_java" ] feed_deps = [ "//third_party/feed:feed_lib_java" ]
feed_java_sources = [ feed_java_sources = [
"//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedBasicLogging.java",
"//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedContentStorage.java", "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedContentStorage.java",
"//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedEventReporter.java", "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedEventReporter.java",
"//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedImageLoader.java", "//chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedImageLoader.java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment