Commit 2132f7fe authored by Katie Dektar's avatar Katie Dektar Committed by Chromium LUCI CQ

Disable flaky chromevox test in msan builds.

Bug: 1169396
Change-Id: Iee21b83a251e8e724327d8cc816194ee71807f7b
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643190
Auto-Submit: Katie Dektar <katie@chromium.org>
Reviewed-by: default avatarNina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846325}
parent c9ad64b4
...@@ -150,14 +150,22 @@ TEST_F('ChromeVoxOptionsTest', 'SmartStickyMode', function() { ...@@ -150,14 +150,22 @@ TEST_F('ChromeVoxOptionsTest', 'SmartStickyMode', function() {
.replay(); .replay();
}); });
}); });
// TODO(crbug.com/1169396): Test times out or crashes flakily in MSAN builds.
TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() { TEST_F_WITH_PREAMBLE(
`
#if defined(MEMORY_SANITIZER)
#define MAYBE_UsePitchChanges DISABLED_UsePitchChanges
#else
#define MAYBE_UsePitchChanges UsePitchChanges
#endif
`,
'ChromeVoxOptionsTest', 'MAYBE_UsePitchChanges', function() {
this.runOnOptionsPage((mockFeedback, evt) => { this.runOnOptionsPage((mockFeedback, evt) => {
const pitchChangesCheckbox = evt.target.find({ const pitchChangesCheckbox = evt.target.find({
role: chrome.automation.RoleType.CHECK_BOX, role: chrome.automation.RoleType.CHECK_BOX,
attributes: { attributes: {
name: 'Change pitch when speaking element types and quoted, deleted, ' + name: 'Change pitch when speaking element types and quoted, ' +
'bolded, parenthesized, or capitalized text.' 'deleted, bolded, parenthesized, or capitalized text.'
} }
}); });
const capitalStrategySelect = evt.target.find({ const capitalStrategySelect = evt.target.find({
...@@ -183,9 +191,9 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() { ...@@ -183,9 +191,9 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() {
'Check box', 'Not checked') 'Check box', 'Not checked')
.call(() => { .call(() => {
assertEquals('false', localStorage['usePitchChanges']); assertEquals('false', localStorage['usePitchChanges']);
// Toggling usePitchChanges affects capitalStrategy. Ensure that the // Toggling usePitchChanges affects capitalStrategy. Ensure that
// preference has been changed and that the 'Increase pitch' option // the preference has been changed and that the 'Increase pitch'
// is hidden. // option is hidden.
assertEquals('announceCapitals', localStorage['capitalStrategy']); assertEquals('announceCapitals', localStorage['capitalStrategy']);
// Open the menu first in order to assert this. // Open the menu first in order to assert this.
...@@ -198,7 +206,8 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() { ...@@ -198,7 +206,8 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() {
}) })
.call(capitalStrategySelect.focus.bind(capitalStrategySelect)) .call(capitalStrategySelect.focus.bind(capitalStrategySelect))
.expectSpeech( .expectSpeech(
'When reading capitals:', 'Speak "cap" before letter', 'Collapsed') 'When reading capitals:', 'Speak "cap" before letter',
'Collapsed')
.call(pitchChangesCheckbox.doDefault.bind(pitchChangesCheckbox)) .call(pitchChangesCheckbox.doDefault.bind(pitchChangesCheckbox))
.expectSpeech( .expectSpeech(
'Change pitch when speaking element types and quoted, ' + 'Change pitch when speaking element types and quoted, ' +
...@@ -220,7 +229,8 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() { ...@@ -220,7 +229,8 @@ TEST_F('ChromeVoxOptionsTest', 'UsePitchChanges', function() {
// assertEquals(undefined, increasePitchOption.state.invisible); // assertEquals(undefined, increasePitchOption.state.invisible);
}) })
.call(capitalStrategySelect.focus.bind(capitalStrategySelect)) .call(capitalStrategySelect.focus.bind(capitalStrategySelect))
.expectSpeech('When reading capitals:', 'Increase pitch', 'Collapsed'); .expectSpeech(
'When reading capitals:', 'Increase pitch', 'Collapsed');
mockFeedback.replay(); mockFeedback.replay();
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment