CrOS SplitSettings: Remove date/time items from browser settings

They are only available in OS settings.

Eliminate type DateTimePageVisibility because neither it nor its only
entry timeZoneSelector are used. I suspect they became unused when the
per-user-timezone feature was added.

Bug: 950007
Test: manual with SplitSettings, double-checked Linux settings
Change-Id: I3ff19aec6e4f9c37b2003cfbc35a0b8812e3ed84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580119Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653658}

chrome/browser/resources/settings/page_visibility.js

@@ -12,7 +12,7 @@
  *   appearance: (boolean|undefined|AppearancePageVisibility),
  *   autofill: (boolean|undefined),
  *   bluetooth: (boolean|undefined),
- *   dateTime: (boolean|undefined|DateTimePageVisibility),
+ *   dateTime: (boolean|undefined),
  *   defaultBrowser: (boolean|undefined),
  *   device: (boolean|undefined),
  *   downloads: (boolean|undefined|DownloadsPageVisibility),
@@ -37,13 +37,6 @@ let PageVisibility;
  */
 let AppearancePageVisibility;
 
-/**
- * @typedef {{
- *   timeZoneSelector: boolean,
- * }}
- */
-let DateTimePageVisibility;
-
 /**
  * @typedef {{
  *   googleDrive: boolean
@@ -101,6 +94,7 @@ cr.define('settings', function() {
       },
       device: showOSSettings,
       advancedSettings: true,
+      dateTime: showOSSettings,
       privacy: {
         searchPrediction: false,
         networkPrediction: false,
@@ -132,6 +126,7 @@ cr.define('settings', function() {
       },
       device: showOSSettings,
       advancedSettings: true,
+      dateTime: showOSSettings,
       privacy: {
         searchPrediction: true,
         networkPrediction: true,

chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -170,7 +170,7 @@
         <iron-selector id="subMenu" selectable="a" attr-for-selected="href"
             role="navigation" on-click="onLinkClick_">
 <if expr="chromeos">
-          <a href="/dateTime">
+          <a href="/dateTime" hidden="[[!pageVisibility.dateTime]]">
             <iron-icon icon="settings:access-time"></iron-icon>
             $i18n{dateTimePageTitle}
           </a>