Do not anchor zoom bubble to off-screen view on Mac

See bug for details. This was causing e.g. Zoom bubble to display
hanging off the side of the screen and/or partially occluded.

Bug: 1117361
Change-Id: If5f56c29cf96c021934679649a1ec058c33acc19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365917Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800219}

chrome/browser/ui/views/frame/browser_view.cc

@@ -1613,6 +1613,15 @@ bool BrowserView::IsTabStripEditable() const {
 }
 
 bool BrowserView::IsToolbarVisible() const {
+#if defined(OS_MAC)
+  // This Mac-only preference disables display of the toolbar in fullscreen mode
+  // so we need to take it into account when determining if the toolbar is
+  // visible - especially as pertains to anchoring views.
+  if (IsFullscreen() && !browser()->profile()->GetPrefs()->GetBoolean(
+                            prefs::kShowFullscreenToolbar)) {
+    return false;
+  }
+#endif
   if (immersive_mode_controller_->ShouldHideTopViews())
     return false;
   // It's possible to reach here before we've been notified of being added to a

chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

@@ -137,8 +137,7 @@ bool IsBrowserFullscreen(Browser* browser) {
 views::View* GetAnchorViewForBrowser(Browser* browser) {
   BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
   if (!IsBrowserFullscreen(browser) || browser_view->IsToolbarVisible() ||
-      browser_view->immersive_mode_controller()->IsRevealed() ||
-      browser->app_controller()) {
+      browser_view->immersive_mode_controller()->IsRevealed()) {
     return browser_view->toolbar_button_provider()->GetAnchorView(
         PageActionIconType::kZoom);
   }