[Extensions] Fix a flaky Open Window Open API test.

This CL moves the test to the interactive_ui_tests test suite.
This fixes the flakiness with the test since the main window
needs focus for the test to work properly.

Bug: 477691
Change-Id: I0d8ab99a80a47c11ed9cc676a5fde23fa21b4c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252600Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780190}

chrome/browser/extensions/window_open_apitest.cc

@@ -66,17 +66,6 @@ class WindowOpenApiTest : public ExtensionApiTest {
   }
 };
 
-// The test uses the chrome.browserAction.openPopup API, which requires that the
-// window can automatically be activated.
-// See comments at BrowserActionInteractiveTest::ShouldRunPopupTest
-// Fails flakily on all platforms. https://crbug.com/477691
-IN_PROC_BROWSER_TEST_F(WindowOpenApiTest, DISABLED_WindowOpen) {
-  extensions::ResultCatcher catcher;
-  ASSERT_TRUE(LoadExtensionIncognito(test_data_dir_
-      .AppendASCII("window_open").AppendASCII("spanning")));
-  EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
-}
-
 bool WaitForTabsPopupsApps(Browser* browser,
                            int num_tabs,
                            int num_popups,

chrome/browser/extensions/window_open_interactive_apitest.cc

@@ -6,6 +6,7 @@
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "content/public/test/browser_test.h"
+#include "extensions/test/result_catcher.h"
 
 namespace extensions {
 
@@ -17,4 +18,13 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenFocus) {
 }
 #endif
 
+// The test uses the chrome.browserAction.openPopup API, which requires that the
+// window can automatically be activated.
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpen) {
+  extensions::ResultCatcher catcher;
+  ASSERT_TRUE(LoadExtensionIncognito(
+      test_data_dir_.AppendASCII("window_open").AppendASCII("spanning")));
+  EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
+}
+
 }  // namespace extensions