Commit 229906ee authored by edchin's avatar edchin Committed by Commit Bot

Update SyncFakeServer egtests todos

This CL uses a separate crbug for device failures vs. simulator.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia1474880fd3236868a4f52354611aff4605cb359
Reviewed-on: https://chromium-review.googlesource.com/960970Reviewed-by: default avataredchin <edchin@chromium.org>
Reviewed-by: default avatarMenglu Huang <huangml@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542859}
parent cbac7cb7
...@@ -131,7 +131,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -131,7 +131,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Tests that a bookmark added on the client (before Sync is enabled) is // Tests that a bookmark added on the client (before Sync is enabled) is
// uploaded to the Sync server once Sync is turned on. // uploaded to the Sync server once Sync is turned on.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncUploadBookmarkOnFirstSync { - (void)FLAKY_testSyncUploadBookmarkOnFirstSync {
[self addBookmark:GURL("https://www.foo.com") withTitle:@"foo"]; [self addBookmark:GURL("https://www.foo.com") withTitle:@"foo"];
...@@ -147,7 +148,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -147,7 +148,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
} }
// Tests that a bookmark added on the client is uploaded to the Sync server. // Tests that a bookmark added on the client is uploaded to the Sync server.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncUploadBookmark { - (void)FLAKY_testSyncUploadBookmark {
ChromeIdentity* identity = [SigninEarlGreyUtils fakeIdentity1]; ChromeIdentity* identity = [SigninEarlGreyUtils fakeIdentity1];
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity( ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
...@@ -162,7 +164,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -162,7 +164,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Tests that a bookmark injected in the FakeServer is synced down to the // Tests that a bookmark injected in the FakeServer is synced down to the
// client. // client.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncDownloadBookmark { - (void)FLAKY_testSyncDownloadBookmark {
[[self class] assertBookmarksWithTitle:@"hoo" expectedCount:0]; [[self class] assertBookmarksWithTitle:@"hoo" expectedCount:0];
chrome_test_util::InjectBookmarkOnFakeSyncServer("http://www.hoo.com", "hoo"); chrome_test_util::InjectBookmarkOnFakeSyncServer("http://www.hoo.com", "hoo");
...@@ -265,7 +268,7 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -265,7 +268,7 @@ void AssertNumberOfEntitiesWithName(int entity_count,
} }
// Tests that autofill profile injected in FakeServer gets synced to client. // Tests that autofill profile injected in FakeServer gets synced to client.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/821490): Reenable the device test.
#if TARGET_IPHONE_SIMULATOR #if TARGET_IPHONE_SIMULATOR
#define MAYBE_testSyncDownloadAutofillProfile testSyncDownloadAutofillProfile #define MAYBE_testSyncDownloadAutofillProfile testSyncDownloadAutofillProfile
#else #else
...@@ -297,7 +300,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -297,7 +300,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Test that update to autofill profile injected in FakeServer gets synced to // Test that update to autofill profile injected in FakeServer gets synced to
// client. // client.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncUpdateAutofillProfile { - (void)FLAKY_testSyncUpdateAutofillProfile {
const std::string kGuid = "2340E83B-5BEE-4560-8F95-5914EF7F539E"; const std::string kGuid = "2340E83B-5BEE-4560-8F95-5914EF7F539E";
const std::string kFullName = "Peter Pan"; const std::string kFullName = "Peter Pan";
...@@ -342,7 +346,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -342,7 +346,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Test that autofill profile deleted from FakeServer gets deleted from client // Test that autofill profile deleted from FakeServer gets deleted from client
// as well. // as well.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncDeleteAutofillProfile { - (void)FLAKY_testSyncDeleteAutofillProfile {
const std::string kGuid = "2340E83B-5BEE-4560-8F95-5914EF7F539E"; const std::string kGuid = "2340E83B-5BEE-4560-8F95-5914EF7F539E";
const std::string kFullName = "Peter Pan"; const std::string kFullName = "Peter Pan";
...@@ -377,7 +382,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -377,7 +382,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Tests that tabs opened on this client are committed to the Sync server and // Tests that tabs opened on this client are committed to the Sync server and
// that the created sessions entities are correct. // that the created sessions entities are correct.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncUploadOpenTabs { - (void)FLAKY_testSyncUploadOpenTabs {
// Create map of canned responses and set up the test HTML server. // Create map of canned responses and set up the test HTML server.
const GURL URL1 = web::test::HttpServer::MakeUrl("http://page1"); const GURL URL1 = web::test::HttpServer::MakeUrl("http://page1");
...@@ -412,7 +418,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -412,7 +418,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Tests that a typed URL (after Sync is enabled) is uploaded to the Sync // Tests that a typed URL (after Sync is enabled) is uploaded to the Sync
// server. // server.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncTypedURLUpload { - (void)FLAKY_testSyncTypedURLUpload {
const GURL mockURL("http://not-a-real-site/"); const GURL mockURL("http://not-a-real-site/");
...@@ -452,7 +459,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -452,7 +459,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
} }
// Tests that typed url is downloaded from sync server. // Tests that typed url is downloaded from sync server.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncTypedUrlDownload { - (void)FLAKY_testSyncTypedUrlDownload {
const GURL mockURL("http://not-a-real-site/"); const GURL mockURL("http://not-a-real-site/");
...@@ -490,7 +498,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -490,7 +498,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Tests that when typed url is deleted on the client, sync the change gets // Tests that when typed url is deleted on the client, sync the change gets
// propagated to server. // propagated to server.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncTypedURLDeleteFromClient { - (void)FLAKY_testSyncTypedURLDeleteFromClient {
const GURL mockURL("http://not-a-real-site/"); const GURL mockURL("http://not-a-real-site/");
...@@ -539,7 +548,8 @@ void AssertNumberOfEntitiesWithName(int entity_count, ...@@ -539,7 +548,8 @@ void AssertNumberOfEntitiesWithName(int entity_count,
// Test that typed url is deleted from client after server sends tombstone for // Test that typed url is deleted from client after server sends tombstone for
// that typed url. // that typed url.
// TODO(crbug.com/814990): Reenable the test. // TODO(crbug.com/814990): Reenable the simulator test.
// TODO(crbug.com/821490): Reenable the device test.
- (void)FLAKY_testSyncTypedURLDeleteFromServer { - (void)FLAKY_testSyncTypedURLDeleteFromServer {
const GURL mockURL("http://not-a-real-site/"); const GURL mockURL("http://not-a-real-site/");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment