Commit 24056b07 authored by Rohit Agarwal's avatar Rohit Agarwal Committed by Commit Bot

Add title to the incognito interstitial.

Screenshot: https://screenshot.googleplex.com/6boukrmENqmXgtP
Bug: 1127852
Change-Id: I672b1b65ddcfbe57d70797c927d5c6c00c1de76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409905Reviewed-by: default avatarAlice Wang <aliceywang@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806964}
parent 3378652a
...@@ -175,6 +175,7 @@ class AccountPickerBottomSheetView implements BottomSheetContent { ...@@ -175,6 +175,7 @@ class AccountPickerBottomSheetView implements BottomSheetContent {
void setUpIncognitoInterstitialView() { void setUpIncognitoInterstitialView() {
// TODO(crbug.com/1103262): Setup the incognito interstitial strings. // TODO(crbug.com/1103262): Setup the incognito interstitial strings.
mLogoImage.setImageResource(R.drawable.location_bar_incognito_badge); mLogoImage.setImageResource(R.drawable.location_bar_incognito_badge);
mAccountPickerTitle.setText(R.string.incognito_interstitial_title);
mIncognitoInterstitialView.setVisibility(View.VISIBLE); mIncognitoInterstitialView.setVisibility(View.VISIBLE);
mAccountPickerSubtitle.setVisibility(View.GONE); mAccountPickerSubtitle.setVisibility(View.GONE);
......
...@@ -409,7 +409,9 @@ public class AccountPickerBottomSheetTest { ...@@ -409,7 +409,9 @@ public class AccountPickerBottomSheetTest {
private void checkIncognitoInterstitialSheet() { private void checkIncognitoInterstitialSheet() {
onView(withId(R.id.account_picker_bottom_sheet_logo)).check(matches(isDisplayed())); onView(withId(R.id.account_picker_bottom_sheet_logo)).check(matches(isDisplayed()));
onView(withId(R.id.account_picker_bottom_sheet_title)).check(matches(isDisplayed())); onView(withId(R.id.account_picker_bottom_sheet_title))
.check(matches(isDisplayed()))
.check(matches(withText(R.string.incognito_interstitial_title)));
onView(withId(R.id.account_picker_bottom_sheet_subtitle)) onView(withId(R.id.account_picker_bottom_sheet_subtitle))
.check(matches(not(isDisplayed()))); .check(matches(not(isDisplayed())));
onView(withId(R.id.account_picker_horizontal_divider)).check(matches(not(isDisplayed()))); onView(withId(R.id.account_picker_horizontal_divider)).check(matches(not(isDisplayed())));
......
...@@ -2415,6 +2415,11 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p ...@@ -2415,6 +2415,11 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p
Waiting for Google Play Services to finish updating Waiting for Google Play Services to finish updating
</message> </message>
<!-- Strings for Incognito Interstitial. -->
<message name="IDS_INCOGNITO_INTERSTITIAL_TITLE" desc="The title of the incognito interstitial bottom sheet.">
Use incognito to sign in temporarily
</message>
<!-- Strings for Streamlined Signin and Unified Consent. --> <!-- Strings for Streamlined Signin and Unified Consent. -->
<message name="IDS_SIGNIN_TITLE" desc="Title for the screen that asks users to sign-in and turn on Sync. [CHAR-LIMIT=27]"> <message name="IDS_SIGNIN_TITLE" desc="Title for the screen that asks users to sign-in and turn on Sync. [CHAR-LIMIT=27]">
Turn on sync? Turn on sync?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment