Commit 24c995b9 authored by avi's avatar avi Committed by Commit bot

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2848163002
Cr-Commit-Position: refs/heads/master@{#468244}
parent b66ac187
...@@ -65,7 +65,8 @@ PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext( ...@@ -65,7 +65,8 @@ PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext(
data = new PartnerBookmarksShim( data = new PartnerBookmarksShim(
Profile::FromBrowserContext(browser_context)->GetPrefs()); Profile::FromBrowserContext(browser_context)->GetPrefs());
browser_context->SetUserData(kPartnerBookmarksShimUserDataKey, data); browser_context->SetUserData(kPartnerBookmarksShimUserDataKey,
base::WrapUnique(data));
data->ReloadNodeMapping(); data->ReloadNodeMapping();
return data; return data;
} }
......
...@@ -33,6 +33,8 @@ class PrefRegistrySyncable; ...@@ -33,6 +33,8 @@ class PrefRegistrySyncable;
// Note that node->GetTitle() returns an original (unmodified) title. // Note that node->GetTitle() returns an original (unmodified) title.
class PartnerBookmarksShim : public base::SupportsUserData::Data { class PartnerBookmarksShim : public base::SupportsUserData::Data {
public: public:
~PartnerBookmarksShim() override;
// Returns an instance of the shim for a given |browser_context|. // Returns an instance of the shim for a given |browser_context|.
static PartnerBookmarksShim* BuildForBrowserContext( static PartnerBookmarksShim* BuildForBrowserContext(
content::BrowserContext* browser_context); content::BrowserContext* browser_context);
...@@ -126,7 +128,6 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data { ...@@ -126,7 +128,6 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data {
private: private:
explicit PartnerBookmarksShim(PrefService* prefs); explicit PartnerBookmarksShim(PrefService* prefs);
~PartnerBookmarksShim() override;
const bookmarks::BookmarkNode* GetNodeByID( const bookmarks::BookmarkNode* GetNodeByID(
const bookmarks::BookmarkNode* parent, const bookmarks::BookmarkNode* parent,
......
...@@ -11,6 +11,8 @@ ...@@ -11,6 +11,8 @@
class ChromeDownloadDelegate class ChromeDownloadDelegate
: public content::WebContentsUserData<ChromeDownloadDelegate> { : public content::WebContentsUserData<ChromeDownloadDelegate> {
public: public:
~ChromeDownloadDelegate() override;
// Returns true iff this request resulted in the tab creating the download // Returns true iff this request resulted in the tab creating the download
// to close. // to close.
static bool EnqueueDownloadManagerRequest(jobject chrome_download_delegate, static bool EnqueueDownloadManagerRequest(jobject chrome_download_delegate,
...@@ -33,7 +35,6 @@ class ChromeDownloadDelegate ...@@ -33,7 +35,6 @@ class ChromeDownloadDelegate
private: private:
explicit ChromeDownloadDelegate(content::WebContents* contents); explicit ChromeDownloadDelegate(content::WebContents* contents);
friend class content::WebContentsUserData<ChromeDownloadDelegate>; friend class content::WebContentsUserData<ChromeDownloadDelegate>;
~ChromeDownloadDelegate() override;
// A reference to the Java ChromeDownloadDelegate object. // A reference to the Java ChromeDownloadDelegate object.
jobject java_ref_; jobject java_ref_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment