Commit 24d1d608 authored by sebsg's avatar sebsg Committed by Commit bot

[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529

TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2805913002
Cr-Commit-Position: refs/heads/master@{#462983}
parent 333a6242
...@@ -1463,7 +1463,6 @@ chrome_test_java_sources = [ ...@@ -1463,7 +1463,6 @@ chrome_test_java_sources = [
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerUnitTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java",
"javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java", "javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java",
......
...@@ -49,6 +49,7 @@ source_set("unit_tests") { ...@@ -49,6 +49,7 @@ source_set("unit_tests") {
"address_normalizer_unittest.cc", "address_normalizer_unittest.cc",
"basic_card_response_unittest.cc", "basic_card_response_unittest.cc",
"currency_formatter_unittest.cc", "currency_formatter_unittest.cc",
"journey_logger_unittest.cc",
"payment_address_unittest.cc", "payment_address_unittest.cc",
"payment_method_data_unittest.cc", "payment_method_data_unittest.cc",
"payment_request_data_util_unittest.cc", "payment_request_data_util_unittest.cc",
...@@ -61,6 +62,7 @@ source_set("unit_tests") { ...@@ -61,6 +62,7 @@ source_set("unit_tests") {
"//base/test:test_support", "//base/test:test_support",
"//components/autofill/core/browser", "//components/autofill/core/browser",
"//components/autofill/core/browser:test_support", "//components/autofill/core/browser:test_support",
"//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/libaddressinput:test_support", "//third_party/libaddressinput:test_support",
] ]
......
...@@ -175,7 +175,7 @@ void JourneyLogger::RecordCanMakePaymentEffectOnShow() { ...@@ -175,7 +175,7 @@ void JourneyLogger::RecordCanMakePaymentEffectOnShow() {
if (was_show_called_) if (was_show_called_)
effect_on_show |= CMP_SHOW_DID_SHOW; effect_on_show |= CMP_SHOW_DID_SHOW;
if (could_make_payment_) if (could_make_payment_)
effect_on_show |= CMP_SHOW_COULD_MAKE_PAYMENT_; effect_on_show |= CMP_SHOW_COULD_MAKE_PAYMENT;
UMA_HISTOGRAM_ENUMERATION("PaymentRequest.CanMakePayment.Used.EffectOnShow", UMA_HISTOGRAM_ENUMERATION("PaymentRequest.CanMakePayment.Used.EffectOnShow",
effect_on_show, CMP_SHOW_MAX); effect_on_show, CMP_SHOW_MAX);
......
...@@ -50,7 +50,7 @@ class JourneyLogger { ...@@ -50,7 +50,7 @@ class JourneyLogger {
// Payment Request is shown to the user. // Payment Request is shown to the user.
static const int CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW = 0; static const int CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW = 0;
static const int CMP_SHOW_DID_SHOW = 1 << 0; static const int CMP_SHOW_DID_SHOW = 1 << 0;
static const int CMP_SHOW_COULD_MAKE_PAYMENT_ = 1 << 1; static const int CMP_SHOW_COULD_MAKE_PAYMENT = 1 << 1;
static const int CMP_SHOW_MAX = 4; static const int CMP_SHOW_MAX = 4;
explicit JourneyLogger(bool is_incognito); explicit JourneyLogger(bool is_incognito);
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment