Commit 24d4592c authored by siggi@chromium.org's avatar siggi@chromium.org

Another attempt to land http://codereview.chromium.org/8589029.

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115


Review URL: http://codereview.chromium.org/8615002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111012 0039d316-1c4b-4281-b951-d872f2087c98
parent fcc69a4d
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
], ],
'include_dirs': [ 'include_dirs': [
'../..', '../..',
'<(PRODUCT_DIR)',
'<(INTERMEDIATE_DIR)', '<(INTERMEDIATE_DIR)',
'<(SHARED_INTERMEDIATE_DIR)/chrome', '<(SHARED_INTERMEDIATE_DIR)/chrome',
], ],
...@@ -42,6 +41,7 @@ ...@@ -42,6 +41,7 @@
'mini_installer/mini_string.h', 'mini_installer/mini_string.h',
'mini_installer/pe_resource.cc', 'mini_installer/pe_resource.cc',
'mini_installer/pe_resource.h', 'mini_installer/pe_resource.h',
'<(INTERMEDIATE_DIR)/packed_files.rc',
], ],
'msvs_settings': { 'msvs_settings': {
'VCCLCompilerTool': { 'VCCLCompilerTool': {
...@@ -209,13 +209,15 @@ ...@@ -209,13 +209,15 @@
'<(PRODUCT_DIR)/<(RULE_INPUT_NAME).7z', '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).7z',
'<(PRODUCT_DIR)/<(RULE_INPUT_NAME).packed.7z', '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).packed.7z',
'<(PRODUCT_DIR)/setup.ex_', '<(PRODUCT_DIR)/setup.ex_',
'<(PRODUCT_DIR)/packed_files.txt', '<(INTERMEDIATE_DIR)/packed_files.rc',
], ],
'action': [ 'action': [
'python', 'python',
'<(create_installer_archive_py_path)', '<(create_installer_archive_py_path)',
'--output_dir=<(PRODUCT_DIR)', '--build_dir', '<(PRODUCT_DIR)',
'--input_file=<(RULE_INPUT_PATH)', '--staging_dir', '<(INTERMEDIATE_DIR)',
'--input_file', '<(RULE_INPUT_PATH)',
'--resource_file_path', '<(INTERMEDIATE_DIR)/packed_files.rc',
# TODO(sgk): may just use environment variables # TODO(sgk): may just use environment variables
#'--distribution=$(CHROMIUM_BUILD)', #'--distribution=$(CHROMIUM_BUILD)',
'--distribution=_google_chrome', '--distribution=_google_chrome',
......
...@@ -49,28 +49,7 @@ BEGIN ...@@ -49,28 +49,7 @@ BEGIN
"#undef APSTUDIO_HIDDEN_SYMBOL\0" "#undef APSTUDIO_HIDDEN_SYMBOL\0"
END END
3 TEXTINCLUDE
BEGIN
"#include ""mini_installer_exe_version.rc""\r\0"
END
#endif // APSTUDIO_INVOKED #endif // APSTUDIO_INVOKED
// This file lists the resources that are going to be packed with the exe.
#include "packed_files.txt"
#endif // English (U.S.) resources #endif // English (U.S.) resources
///////////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////////
#ifndef APSTUDIO_INVOKED
/////////////////////////////////////////////////////////////////////////////
//
// Generated from the TEXTINCLUDE 3 resource.
//
#include "mini_installer_exe_version.rc"
/////////////////////////////////////////////////////////////////////////////
#endif // not APSTUDIO_INVOKED
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
// //
// Version // Version
// //
#include "verrsrc.h"
VS_VERSION_INFO VERSIONINFO VS_VERSION_INFO VERSIONINFO
FILEVERSION @MAJOR@,@MINOR@,@BUILD@,@PATCH@ FILEVERSION @MAJOR@,@MINOR@,@BUILD@,@PATCH@
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment