Commit 2590835e authored by jianli@chromium.org's avatar jianli@chromium.org

Change to pass by const reference for a couple GCMDriverDesktop methods

BUG=none

Review URL: https://codereview.chromium.org/301243019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274453 0039d316-1c4b-4281-b951-d872f2087c98
parent dce1d3a7
...@@ -746,8 +746,9 @@ void GCMDriverDesktop::SendFinished(const std::string& app_id, ...@@ -746,8 +746,9 @@ void GCMDriverDesktop::SendFinished(const std::string& app_id,
callback.Run(message_id, result); callback.Run(message_id, result);
} }
void GCMDriverDesktop::MessageReceived(const std::string& app_id, void GCMDriverDesktop::MessageReceived(
GCMClient::IncomingMessage message) { const std::string& app_id,
const GCMClient::IncomingMessage& message) {
DCHECK(ui_thread_->RunsTasksOnCurrentThread()); DCHECK(ui_thread_->RunsTasksOnCurrentThread());
// Drop the event if signed out. // Drop the event if signed out.
...@@ -790,7 +791,7 @@ void GCMDriverDesktop::GCMClientReady() { ...@@ -790,7 +791,7 @@ void GCMDriverDesktop::GCMClientReady() {
} }
void GCMDriverDesktop::GetGCMStatisticsFinished( void GCMDriverDesktop::GetGCMStatisticsFinished(
GCMClient::GCMStatistics stats) { const GCMClient::GCMStatistics& stats) {
DCHECK(ui_thread_->RunsTasksOnCurrentThread()); DCHECK(ui_thread_->RunsTasksOnCurrentThread());
// Normally request_gcm_statistics_callback_ would not be null. // Normally request_gcm_statistics_callback_ would not be null.
......
...@@ -120,13 +120,13 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer { ...@@ -120,13 +120,13 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
const std::string& message_id, const std::string& message_id,
GCMClient::Result result); GCMClient::Result result);
void MessageReceived(const std::string& app_id, void MessageReceived(const std::string& app_id,
GCMClient::IncomingMessage message); const GCMClient::IncomingMessage& message);
void MessagesDeleted(const std::string& app_id); void MessagesDeleted(const std::string& app_id);
void MessageSendError(const std::string& app_id, void MessageSendError(const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details); const GCMClient::SendErrorDetails& send_error_details);
void GCMClientReady(); void GCMClientReady();
void GetGCMStatisticsFinished(GCMClient::GCMStatistics stats); void GetGCMStatisticsFinished(const GCMClient::GCMStatistics& stats);
// Flag to indicate if GCM is enabled. // Flag to indicate if GCM is enabled.
bool gcm_enabled_; bool gcm_enabled_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment