Commit 2616eba5 authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

Fix WTF::StringImpl in webkit.natvis

When WTF::StringImpl is displayed in the VisualStudio
debugger, and when the string is expanded, each character
should be displayed, but each character is typed as
StringImpl and that code points cannot be seen.

This patch fixes it for both 8bit and 16bit cases.

r603419 (CL:1288930) removed (wchar_t*) because local test
did not show the differences, but it was because the natvis
in the DLL was prioritized over the local natvis. When both
files were fixed, the symptom was fixed properly.

Change-Id: I68ff0f83456a4e99db803f7140b6e0d6a7630bba
Reviewed-on: https://chromium-review.googlesource.com/c/1337671Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608454}
parent 9cf36366
...@@ -33,8 +33,8 @@ ...@@ -33,8 +33,8 @@
<Expand> <Expand>
<Item Name="Length">length_</Item> <Item Name="Length">length_</Item>
<Item Name="Hash">hash_</Item> <Item Name="Hash">hash_</Item>
<Item Name="AsciiText" Condition="is8_bit_">(this+1),[length_]s</Item> <Item Name="AsciiText" Condition="is8_bit_">(char*)(this+1),[length_]s</Item>
<Item Name="UnicodeText" Condition="!is8_bit_">(this+1),[length_]su</Item> <Item Name="UnicodeText" Condition="!is8_bit_">(wchar_t*)(this+1),[length_]su</Item>
</Expand> </Expand>
</Type> </Type>
<Type Name="WTF::AtomicString"> <Type Name="WTF::AtomicString">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment