Commit 267e2588 authored by Mike Jackson's avatar Mike Jackson Committed by Commit Bot

dpwa: Remove parameterization for WebApp Provider Unit Test

Removes the parameterization for all tests in the
web_app_provider_unittest.cc file, now that
kDesktopPWAsWithoutExtensions flag is always true.

Bug: 1065748
Change-Id: I1bebc1de80fc8cdb3f93d49f07acd938f5acfb09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453352
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814570}
parent 615257a6
...@@ -4,27 +4,15 @@ ...@@ -4,27 +4,15 @@
#include "chrome/browser/web_applications/web_app_provider.h" #include "chrome/browser/web_applications/web_app_provider.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/web_applications/test/web_app_test.h" #include "chrome/browser/web_applications/test/web_app_test.h"
#include "chrome/browser/web_applications/web_app_registrar.h" #include "chrome/browser/web_applications/web_app_registrar.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile.h"
namespace web_app { namespace web_app {
class WebAppProviderUnitTest class WebAppProviderUnitTest : public WebAppTest {
: public WebAppTest,
public ::testing::WithParamInterface<ProviderType> {
public: public:
WebAppProviderUnitTest() { WebAppProviderUnitTest() = default;
if (GetParam() == ProviderType::kWebApps) {
scoped_feature_list_.InitAndEnableFeature(
features::kDesktopPWAsWithoutExtensions);
} else if (GetParam() == ProviderType::kBookmarkApps) {
scoped_feature_list_.InitAndDisableFeature(
features::kDesktopPWAsWithoutExtensions);
}
}
WebAppProviderUnitTest(const WebAppProviderUnitTest&) = delete; WebAppProviderUnitTest(const WebAppProviderUnitTest&) = delete;
WebAppProviderUnitTest& operator=(const WebAppProviderUnitTest&) = delete; WebAppProviderUnitTest& operator=(const WebAppProviderUnitTest&) = delete;
~WebAppProviderUnitTest() override = default; ~WebAppProviderUnitTest() override = default;
...@@ -37,19 +25,12 @@ class WebAppProviderUnitTest ...@@ -37,19 +25,12 @@ class WebAppProviderUnitTest
WebAppProvider* provider() { return provider_; } WebAppProvider* provider() { return provider_; }
private: private:
base::test::ScopedFeatureList scoped_feature_list_;
WebAppProvider* provider_; WebAppProvider* provider_;
}; };
TEST_P(WebAppProviderUnitTest, Registrar) { TEST_F(WebAppProviderUnitTest, Registrar) {
AppRegistrar& registrar = provider()->registrar(); AppRegistrar& registrar = provider()->registrar();
EXPECT_FALSE(registrar.IsInstalled("unknown")); EXPECT_FALSE(registrar.IsInstalled("unknown"));
} }
INSTANTIATE_TEST_SUITE_P(All,
WebAppProviderUnitTest,
::testing::ValuesIn({ProviderType::kBookmarkApps,
ProviderType::kWebApps}));
} // namespace web_app } // namespace web_app
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment