Commit 28324ae4 authored by Daniel Classon's avatar Daniel Classon Committed by Commit Bot

[OsSettingsMetrics] Remove Per Session Tracker inherited class

Removes UserActionRecorder as an inherited class of the Per Session
tracker in preparation for an update to the UserActionRecorder class.

Bug: 1133553
Change-Id: I769e1723a107d4a6a0e32698068fa8a7cc34026f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440307
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812501}
parent d3d8dee8
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
#define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_PER_SESSION_SETTINGS_USER_ACTION_TRACKER_H_ #define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_PER_SESSION_SETTINGS_USER_ACTION_TRACKER_H_
#include "base/time/time.h" #include "base/time/time.h"
#include "chrome/browser/ui/webui/settings/chromeos/search/user_action_recorder.mojom.h"
#include "mojo/public/cpp/bindings/pending_receiver.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h" #include "mojo/public/cpp/bindings/receiver.h"
...@@ -17,22 +16,21 @@ namespace settings { ...@@ -17,22 +16,21 @@ namespace settings {
// This class is only meant to track actions from an individual settings // This class is only meant to track actions from an individual settings
// session; if the settings window is closed and reopened again, a new instance // session; if the settings window is closed and reopened again, a new instance
// should be created for that new session. // should be created for that new session.
class PerSessionSettingsUserActionTracker : public mojom::UserActionRecorder { class PerSessionSettingsUserActionTracker {
public: public:
PerSessionSettingsUserActionTracker(); PerSessionSettingsUserActionTracker();
PerSessionSettingsUserActionTracker( PerSessionSettingsUserActionTracker(
const PerSessionSettingsUserActionTracker& other) = delete; const PerSessionSettingsUserActionTracker& other) = delete;
PerSessionSettingsUserActionTracker& operator=( PerSessionSettingsUserActionTracker& operator=(
const PerSessionSettingsUserActionTracker& other) = delete; const PerSessionSettingsUserActionTracker& other) = delete;
~PerSessionSettingsUserActionTracker() override; ~PerSessionSettingsUserActionTracker();
// mojom::UserActionRecorder: void RecordPageFocus();
void RecordPageFocus() override; void RecordPageBlur();
void RecordPageBlur() override; void RecordClick();
void RecordClick() override; void RecordNavigation();
void RecordNavigation() override; void RecordSearch();
void RecordSearch() override; void RecordSettingChange();
void RecordSettingChange() override;
private: private:
friend class PerSessionSettingsUserActionTrackerTest; friend class PerSessionSettingsUserActionTrackerTest;
...@@ -61,8 +59,6 @@ class PerSessionSettingsUserActionTracker : public mojom::UserActionRecorder { ...@@ -61,8 +59,6 @@ class PerSessionSettingsUserActionTracker : public mojom::UserActionRecorder {
// The last time at which a page blur event was received; if no blur events // The last time at which a page blur event was received; if no blur events
// have been received, this field is_null(). // have been received, this field is_null().
base::TimeTicks last_blur_timestamp_; base::TimeTicks last_blur_timestamp_;
mojo::Receiver<mojom::UserActionRecorder> receiver_{this};
}; };
} // namespace settings } // namespace settings
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment