Skip to content

GitLab

T
tangled
Commit 28e7d0c1 authored by Gyuyoung Kim's avatar Gyuyoung Kim Committed by Commit Bot
Browse files
Options

[css-grid] Migrate flex-item-grid-container-percentage-rows.html to WPT 

This CL migrates flex-item-grid-container-percentage-rows
[-expected].html from fast/css-grid-layout to
external/wpt/css/css-grid/grid-items with WPT styles,
adding links to the relevant specs, and test description.

Additionally, this test is renamed to
flex-item-grid-container-percentage-rows-001[-ref].html
to be align with existing tests.

Bug: 1063749
Change-Id: I2959664d4f110190f87ba66416e46df747257cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147762
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: default avatarManuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#759579}
parent 56da0d79
Show whitespace changes
Inline Side-by-side
Showing with 45 additions and 44 deletions
third_party/blink/web_tests/external/wpt/css/css-grid/grid-definition/flex-item-grid-container-percentage-rows-001.html 0 → 100644
View file @ 28e7d0c1
<!DOCTYPE html>
<title>CSS Grid Layout Test: Percentage rows resolution in a flex item grid container</title>
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#grid-item">
<link rel="help" href="https://drafts.csswg.org/css-flexbox/#definite-sizes">
<link rel="issue" href="https://bugs.chromium.org/p/chromium/issues/detail?id=617876">
<link rel="match" href="../reference/flex-item-grid-container-percentage-rows-001-ref.html">
<meta name="assert" content="This test ensures that percentage rows are properly resolved for a grid container that is a flex item with a definite height.">
<link rel="stylesheet" href="/css/support/grid.css">
<style>
.flex {
display: flex;
flex-direction: column;
width: 200px;
height: 200px;
border: 5px solid;
}
.flexitem {
flex: 1;
background: magenta;
}
.grid {
display: grid;
grid: 50% / 1fr;
}
.griditem {
background: cyan;
}
</style>
<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>
<div class="flex">
<div class="flexitem grid">
<div class="griditem"></div>
</div>
</div>
third_party/blink/web_tests/fast/css-grid-layout/flex-item-grid-container-percentage-rows-expected.html → third_party/blink/web_tests/external/wpt/css/css-grid/reference/flex-item-grid-container-percentage-rows-001-ref.html
View file @ 28e7d0c1
<!DOCTYPE html>
<style>
.wrapper {
width: 200px;
border: 5px solid;
......@@ -17,10 +16,8 @@
.cyan {
background: cyan;
}
</style>
<p>This test checks that percentage rows are properly resolved for a grid container that is a flex item with a definite height.</p>
<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>
<div class="wrapper">
......
third_party/blink/web_tests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html deleted 100644 → 0
View file @ 56da0d79
<!DOCTYPE html>
<link href="resources/grid.css" rel="stylesheet">
<style>
.flex {
display: flex;
flex-direction: column;
width: 200px;
height: 200px;
border: 5px solid;
}
.flexitem {
flex: 1;
background: magenta;
}
.grid {
display: grid;
grid: 50% / 1fr;
}
.griditem {
background: cyan;
}
</style>
<p>This test checks that percentage rows are properly resolved for a grid container that is a flex item with a definite height.</p>
<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>
<div class="flex">
<div class="flexitem grid">
<div class="griditem"></div>
</div>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment