Commit 29737099 authored by Bo Liu's avatar Bo Liu Committed by Commit Bot

android: Disable gpu timeout for in-process gpu

In-process GPU has lower stability guarantees as it cannot be restarted.
It does not have a watchdog timer. Establish channel timeout is not
useful as it's only waiting for a thread to start and do work. So it can
really only trigger for false positives.

So disable the timeout for in-process GPU.

Bug: 1068670
Change-Id: I047e07c29d74e8b68a8bcf2ecdb333f066c377fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140818Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757545}
parent ef1ae21b
...@@ -410,8 +410,14 @@ void BrowserGpuChannelHostFactory::RestartTimeout() { ...@@ -410,8 +410,14 @@ void BrowserGpuChannelHostFactory::RestartTimeout() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// Only implement timeout on Android, which does not have a software fallback. // Only implement timeout on Android, which does not have a software fallback.
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
if (base::CommandLine::ForCurrentProcess()->HasSwitch( base::CommandLine* cl = base::CommandLine::ForCurrentProcess();
switches::kDisableTimeoutsForProfiling)) { if (cl->HasSwitch(switches::kDisableTimeoutsForProfiling)) {
return;
}
// Only enable it for out of process GPU. In-process generally only has false
// positives.
if (cl->HasSwitch(switches::kSingleProcess) ||
cl->HasSwitch(switches::kInProcessGPU)) {
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment