Commit 2bb4e5b1 authored by wutao's avatar wutao Committed by Commit Bot

cros: Add TODO to remove deps for Shortcuts Viewer

This cl adds TODO to remove the dependency on aura::Window in Keyboard
Shortcuts Viewer. In addition, this cl removes unused deps and include.

Bug: 833673
Test: Manual
Change-Id: Icc4fd0726cace1971674e371bb5053b20575933b
Reviewed-on: https://chromium-review.googlesource.com/1014663Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551348}
parent 53f3dbb2
...@@ -7,7 +7,6 @@ include_rules = [ ...@@ -7,7 +7,6 @@ include_rules = [
"+ash/components/shortcut_viewer", "+ash/components/shortcut_viewer",
"+ash/public", "+ash/public",
"+ash/shell.h", "+ash/shell.h",
"+ash/wm/window_util.h",
"+chrome/browser/ui/ash/ksv", "+chrome/browser/ui/ash/ksv",
] ]
......
...@@ -6,11 +6,11 @@ ...@@ -6,11 +6,11 @@
#include "ash/components/shortcut_viewer/views/keyboard_shortcut_view.h" #include "ash/components/shortcut_viewer/views/keyboard_shortcut_view.h"
#include "ash/shell.h" #include "ash/shell.h"
#include "ash/wm/window_util.h"
namespace keyboard_shortcut_viewer_util { namespace keyboard_shortcut_viewer_util {
void ShowKeyboardShortcutViewer() { void ShowKeyboardShortcutViewer() {
// TODO(https://crbug.com/833673): Remove the dependency on aura::Window.
keyboard_shortcut_viewer::KeyboardShortcutView::Show( keyboard_shortcut_viewer::KeyboardShortcutView::Show(
ash::Shell::GetRootWindowForNewWindows()); ash::Shell::GetRootWindowForNewWindows());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment