DPWA: Remove expired Shortcuts Menu Histograms and enums

This CL obsoletes the following histograms and their corresponding enums
  1. Apps.ShortcutsMenu.Registration.Win.Result
  2. Apps.ShortcutsMenu.Unregistration.Win.Result

These histograms were used to gauge feature health for Shortcuts Menu
on Windows which launched in M85. The feature has remained healthy into
M87. So, we can safely obsolete these histograms and remove the
corresponding instrumentation code from Chromium.

Bug: 1125647,1125648
Change-Id: Ic0fa250aa431562a453ab783f47f10bc129a8444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632148Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845328}

chrome/browser/web_applications/components/web_app_shortcuts_menu_win.cc

@@ -16,7 +16,6 @@
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
-#include "base/metrics/histogram_functions.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ -39,47 +38,6 @@ namespace {
 
 constexpr int kMaxJumpListItems = 10;
 
-// UMA metric name for shortcuts menu registration result.
-constexpr const char kRegistrationResultMetric[] =
-    "Apps.ShortcutsMenu.Registration.Win.Result";
-
-// UMA metric name for shortcuts menu unregistration result.
-constexpr const char kUnregistrationResultMetric[] =
-    "Apps.ShortcutsMenu.Unregistration.Win.Result";
-
-// Result of shortcuts menu registration process.
-// These values are persisted to logs. Entries should not be renumbered and
-// numeric values should never be reused.
-enum class RegistrationResult {
-  kSuccess = 0,
-  kFailedToWriteIcoFilesToDisk = 1,
-  kFailedToBeginUpdate = 2,
-  kFailedToAddTasks = 3,
-  kFailedToCommitUpdate = 4,
-  kMaxValue = kFailedToCommitUpdate
-};
-
-// Result of shortcuts menu unregistration process.
-// These values are persisted to logs. Entries should not be renumbered and
-// numeric values should never be reused.
-enum class UnregistrationResult {
-  kSuccess = 0,
-  kFailedToDeleteJumpList = 1,
-  kMaxValue = kFailedToDeleteJumpList
-};
-
-// Records UMA metric for the result of shortcuts menu registration.
-// TODO(https://crbug.com/1076042): Add tests using HistogramTester to verify
-// that histograms are recorded.
-void RecordRegistration(RegistrationResult result) {
-  base::UmaHistogramEnumeration(kRegistrationResultMetric, result);
-}
-
-// Records UMA metric for the result of shortcuts menu unregistration.
-void RecordUnregistration(UnregistrationResult result) {
-  base::UmaHistogramEnumeration(kUnregistrationResultMetric, result);
-}
-
 base::FilePath GetShortcutsMenuIconsDirectory(
     const base::FilePath& shortcut_data_dir) {
   static constexpr base::FilePath::CharType kShortcutsMenuIconsDirectoryName[] =
@@ -148,17 +106,14 @@ void RegisterShortcutsMenuWithOsTask(
   // shortcuts vector.
   if (!WriteShortcutsMenuIconsToIcoFiles(shortcut_data_dir,
                                          shortcuts_menu_icons_bitmaps)) {
-    RecordRegistration(RegistrationResult::kFailedToWriteIcoFilesToDisk);
     return;
   }
 
   base::string16 app_user_model_id =
       GenerateAppUserModelId(profile_path, app_id);
   JumpListUpdater jumplist_updater(app_user_model_id);
-  if (!jumplist_updater.BeginUpdate()) {
-    RecordRegistration(RegistrationResult::kFailedToBeginUpdate);
+  if (!jumplist_updater.BeginUpdate())
     return;
-  }
 
   ShellLinkItemList shortcut_list;
 
@@ -187,16 +142,8 @@ void RegisterShortcutsMenuWithOsTask(
     shortcut_list.push_back(std::move(shortcut_link));
   }
 
-  if (!jumplist_updater.AddTasks(shortcut_list)) {
-    RecordRegistration(RegistrationResult::kFailedToAddTasks);
-    return;
-  }
-  if (!jumplist_updater.CommitUpdate()) {
-    RecordRegistration(RegistrationResult::kFailedToCommitUpdate);
-    return;
-  }
-
-  RecordRegistration(RegistrationResult::kSuccess);
+  if (jumplist_updater.AddTasks(shortcut_list))
+    jumplist_updater.CommitUpdate();
 }
 
 void RegisterShortcutsMenuWithOs(
@@ -215,13 +162,8 @@ void RegisterShortcutsMenuWithOs(
 
 bool UnregisterShortcutsMenuWithOs(const AppId& app_id,
                                    const base::FilePath& profile_path) {
-  if (!JumpListUpdater::DeleteJumpList(
-          GenerateAppUserModelId(profile_path, app_id))) {
-    RecordUnregistration(UnregistrationResult::kFailedToDeleteJumpList);
-    return false;
-  }
-  RecordUnregistration(UnregistrationResult::kSuccess);
-  return true;
+  return JumpListUpdater::DeleteJumpList(
+      GenerateAppUserModelId(profile_path, app_id));
 }
 
 namespace internals {

tools/metrics/histograms/enums.xml

@@ -68616,6 +68616,9 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf
 </enum>
 
 <enum name="ShortcutsMenuRegistrationWinResult">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <summary>
     Result of registering app icon shortcuts menu for PWA on Windows
   </summary>
@@ -68627,6 +68630,9 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf
 </enum>
 
 <enum name="ShortcutsMenuUnregistrationWinResult">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <summary>
     Result of registering app icon shortcuts menu for PWA on Windows
   </summary>

tools/metrics/histograms/histograms_xml/apps/histograms.xml

@@ -1748,6 +1748,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 
 <histogram name="Apps.ShortcutsMenu.Registration.Win.Result"
     enum="ShortcutsMenuRegistrationWinResult" expires_after="M87">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <owner>cmumford@chromium.org</owner>
   <owner>rahsin@microsoft.com</owner>
   <summary>
@@ -1757,6 +1760,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 
 <histogram name="Apps.ShortcutsMenu.Unregistration.Win.Result"
     enum="ShortcutsMenuUnregistrationWinResult" expires_after="M87">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <owner>cmumford@chromium.org</owner>
   <owner>rahsin@microsoft.com</owner>
   <summary>