Commit 2c5ed73c authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

Fix duplicate ordinals in HidReportItem

Two fields were given the ordinal @21. Due to a bug in the bindings
generator, this was allowed. In practice this meant the ordinal for the
second @21 field was actually @22, and all subsequent ordinals should be
bumped by one.

This CL corrects the assigned ordinals to reflect the reality of the
generated code. The stable format of this structure is unaffected by
this change.

NOPRESUBMIT=True

Bug: None
Change-Id: I82591eb4f36fa8e1121d5c0edfbfaa1656f57e31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422482
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809546}
parent 3936e7e2
...@@ -224,14 +224,14 @@ struct HidReportItem { ...@@ -224,14 +224,14 @@ struct HidReportItem {
// fields that define the unit system and the exponents on units of length, // fields that define the unit system and the exponents on units of length,
// mass, time, temperature, current, and luminous intensity. Bits [28:31] are // mass, time, temperature, current, and luminous intensity. Bits [28:31] are
// reserved and should be set to zero. // reserved and should be set to zero.
uint32 unit@21; uint32 unit@22;
// A single report item may define multiple same-sized fields within a report. // A single report item may define multiple same-sized fields within a report.
// |report_size| and |report_count| define the size of one field (in bits) and // |report_size| and |report_count| define the size of one field (in bits) and
// the number of fields within the item. The total size of this item in bits // the number of fields within the item. The total size of this item in bits
// is equal to the product of these values. // is equal to the product of these values.
uint32 report_size@22; uint32 report_size@23;
uint32 report_count@23; uint32 report_count@24;
}; };
// Contains information collected from the HID report descriptor regarding a // Contains information collected from the HID report descriptor regarding a
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment