Commit 2cc41f0a authored by Chris Palmer's avatar Chris Palmer Committed by Commit Bot

Turn off `init_stack_vars` on Android.

On x86 as well as on ARM. It breaks Java test
`JavaBridgeCoercionTest.testPassNull`.

There is probably an underlying bug that we need to fix.

Bug: 1131993, 977230
Change-Id: Ie579516a06d13577fcb4a61fa515a2d873bfcd15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429233Reviewed-by: default avatarPavel Yatsuk <pavely@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810834}
parent 8420b2c2
...@@ -123,13 +123,12 @@ declare_args() { ...@@ -123,13 +123,12 @@ declare_args() {
# recognizable in the debugger, and crashes on memory accesses through # recognizable in the debugger, and crashes on memory accesses through
# uninitialized pointers. # uninitialized pointers.
# #
# TODO(crbug.com/977230): Enabling this when 'is_android' is true breaks # TODO(crbug.com/1131993): Enabling this when 'is_android' is true breaks
# content_shell_test_apk on android-kitkat-arm-rel. Enabling this when # content_shell_test_apk on both ARM and x86.
# 'use_xcode_clang' is true may call an old clang that doesn't support #
# auto-init. # TODO(crbug.com/977230): Enabling this when 'use_xcode_clang' is true may
init_stack_vars = # call an old clang that doesn't support auto-init.
!(is_android && (target_cpu == "arm" || target_cpu == "arm64")) && init_stack_vars = !is_android && !use_xcode_clang
!use_xcode_clang
# This argument is to control whether enabling text section splitting in the # This argument is to control whether enabling text section splitting in the
# final binary. When enabled, the separated text sections with prefix # final binary. When enabled, the separated text sections with prefix
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment