Commit 2fb88bb8 authored by Liviu Tinta's avatar Liviu Tinta Committed by Commit Bot

Use integer coordinates for Actions.pointerMove.

The 2 tests were failing on wpt.fyi because the coordinates passed to Actions.pointerMove were not integers (like on local run). Since Actions.pointerMove expects integer coordinates, the tests were failing with an exception.
Use Math.ceil on coordinates passed to Actions.pointerMove. Apply memory leak fix.

Bug: 810882
Change-Id: I399f763fa03ebd98167fd060ad1769e8dd7f9d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132950
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755524}
parent b77ab3ce
......@@ -48,6 +48,7 @@
<wc-wc id="wc-wc"></wc-wc>
<div id="log"></div>
<script>
function onLoad(){
var logDiv = document.getElementById("log");
function logMessage(message){
var log = document.createElement("div");
......@@ -81,7 +82,6 @@
"gotpointercapture@content", "pointerup@content",
"lostpointercapture@content"]);
resolve_test();
wc_shadow_dom_test.done();
});
}
});
......@@ -96,11 +96,10 @@
resolve_test = null;
reject_test = null;
}
function onLoad(){
if(window.promise_test){
promise_test(function(t){
return new Promise(function(resolve, reject){
promise_test(async function(t){
var actions_promise;
return new Promise(async function(resolve, reject){
wc_shadow_dom_test = t;
resolve_test = resolve;
reject_test = reject;
......@@ -109,11 +108,14 @@
});
var contentRect = content.getBoundingClientRect();
var actions = new test_driver.Actions();
var actions_promise = actions
.pointerMove(contentRect.x, contentRect.y)
actions_promise = actions
.pointerMove(Math.ceil(contentRect.x), Math.ceil(contentRect.y))
.pointerDown({button: actions.ButtonType.LEFT})
.pointerUp({button: actions.ButtonType.LEFT})
.send();
}).then(async()=>{
await actions_promise;
t.done();
});
}, "PointerCapture works for custom element Shadow DOM.");
}
......
......@@ -34,6 +34,7 @@
<div id="shadowhost"></div>
<div id="log"></div>
<script>
function onLoad(){
var logDiv = document.getElementById("log");
function logMessage(message){
var log = document.createElement("div");
......@@ -72,7 +73,6 @@
"gotpointercapture@content", "pointerup@content",
"lostpointercapture@content"]);
resolve_test();
shadow_dom_test.done();
});
}
});
......@@ -88,10 +88,10 @@
reject_test = null;
}
function onLoad(){
if(window.promise_test){
promise_test(function(t){
return new Promise(function(resolve, reject){
promise_test(async function(t){
var actions_promise;
return new Promise(async function(resolve, reject){
shadow_dom_test = t;
resolve_test = resolve;
reject_test = reject;
......@@ -100,11 +100,14 @@
});
var contentRect = content.getBoundingClientRect();
var actions = new test_driver.Actions();
var actions_promise = actions
.pointerMove(contentRect.x, contentRect.y)
actions_promise = actions
.pointerMove(Math.ceil(contentRect.x), Math.ceil(contentRect.y))
.pointerDown({button: actions.ButtonType.LEFT})
.pointerUp({button: actions.ButtonType.LEFT})
.send();
}).then(async ()=>{
await actions_promise;
t.done();
});
}, "PointerCapture works for Shadow DOM element.");
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment