Skip to content

GitLab

T
tangled
Commit 2feae05a authored by Mustaq Ahmed's avatar Mustaq Ahmed Committed by Commit Bot
Browse files
Options

Fix web-tests that failed with UAv2 same-origin visibility. 

The two fullscreen tests change back to pre-UAv2 expectations.  The
user activation query api test shows consumption in transient state
only.

Fixed: 922725
Change-Id: Ia7402d4ce08a89edef13bcba2dd2c4405739e872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883118Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710000}
parent 192a9aee
Show whitespace changes
Inline Side-by-side
Showing with 5 additions and 46 deletions
third_party/blink/web_tests/TestExpectations
View file @ 2feae05a
......@@ -26,12 +26,6 @@ crbug.com/906791 external/wpt/fullscreen/api/element-ready-check-allowed-cross-o
crbug.com/860713 external/wpt/bluetooth/requestDevice/cross-origin-iframe.sub.https.html [ Failure Timeout ]
crbug.com/860713 external/wpt/bluetooth/requestDevice/request-from-sandboxed-iframe.https.html [ Failure Timeout ]
# The following tests fail with UserActivationSameOriginVisibility plus UAv2.
crbug.com/922725 external/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.tentative.html [ Failure ]
crbug.com/922725 external/wpt/html/user-activation/activation-api-iframe-no-activate.tenative.html [ Failure ]
crbug.com/922725 fullscreen/full-screen-iframe-zIndex.html [ Timeout ]
crbug.com/922725 virtual/android/fullscreen/full-screen-iframe-zIndex.html [ Timeout ]
# The following tests would pass with User Activation Delegation.
crbug.com/928838 external/wpt/html/user-activation/activation-transfer-with-click.tentative.html [ Failure ]
crbug.com/928838 external/wpt/html/user-activation/activation-transfer-cross-origin-with-click.sub.tentative.html [ Failure ]
......
third_party/blink/web_tests/external/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.tentative.html
View file @ 2feae05a
......@@ -21,8 +21,8 @@ window.onload = function() {
iframes[0].contentDocument.onfullscreenchange = t.step_func(function() {
assert_equals(document.fullscreenElement, iframes[0]);
trusted_request(t, iframes[1].contentDocument.body, iframes[0].contentDocument.body);
iframes[1].contentDocument.onfullscreenchange = t.unreached_func("fullscreenchange event");
iframes[1].contentDocument.onfullscreenerror = t.step_func_done();
iframes[1].contentDocument.onfullscreenerror = t.unreached_func("fullscreenerror event");
iframes[1].contentDocument.onfullscreenchange = t.step_func_done();
});
});
};
......
third_party/blink/web_tests/external/wpt/html/user-activation/activation-api-iframe-no-activate.tenative.html
View file @ 2feae05a
......@@ -32,9 +32,9 @@
// click in parent document
test_driver.click(document.getElementById('instructions'));
} else if (msg.type == 'child-one-report') {
// state should be false after asked to report
// only the transient state should be false after asked to report
assert_false(msg.isActive);
assert_false(msg.hasBeenActive);
assert_true(msg.hasBeenActive);
t.done();
}
}));
......
third_party/blink/web_tests/fullscreen/full-screen-iframe-zIndex-expected.html
View file @ 2feae05a
<!DOCTYPE html>
<html>
<head>
<style>
#block1 {
width: 200px;
height: 100px;
border: 4px solid darkgreen;
background-color: white;
z-index: 0;
}
#block2 {
width: 100px;
height: 50px;
border: 4px solid darkred;
background-color: red;
z-index: 500;
position: relative;
left: 50px;
top: 25px;
}
</style>
</head>
<body>
<div>This tests that an element with a positive z-index appears behind the full screen iframe element.
After entering full screen mode, the whole screen should be white.
Click <button>go full screen</button> to run the test.</div>
<div id="block2"></div>
<iframe id="block1"></iframe>
<div>EVENT(webkitfullscreenerror)<br>END OF TEST<br></div>
</body>
</html>
third_party/blink/web_tests/fullscreen/full-screen-iframe-zIndex-expected.txt deleted 100644 → 0
View file @ 192a9aee
CONSOLE WARNING: line 20: Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture.
third_party/blink/web_tests/fullscreen/full-screen-iframe-zIndex.html
View file @ 2feae05a
......@@ -7,10 +7,7 @@
function init() {
var iframe = document.getElementById('block1');
var element = iframe.contentDocument.documentElement;
if (!internals.runtimeFlags.userActivationV2Enabled)
waitForEventAndEnd(element, 'webkitfullscreenchange');
else
waitForEventAndEnd(element, 'webkitfullscreenerror');
runWithKeyDown(goFullScreen);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment