Commit 3097ab40 authored by Camillo Bruni's avatar Camillo Bruni Committed by Commit Bot

[gin ] Migrate to new-style V8 callbacks

Change-Id: Ib50dbd2d3785cb5e72a5dd8381db8d7220a86446
Reviewed-on: https://chromium-review.googlesource.com/803475
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521346}
parent 2087f0bf
......@@ -49,7 +49,7 @@ IndexedPropertyInterceptor* IndexedInterceptorFromV8(
return PerIsolateData::From(isolate)->GetIndexedPropertyInterceptor(base);
}
void NamedPropertyGetter(v8::Local<v8::String> property,
void NamedPropertyGetter(v8::Local<v8::Name> property,
const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Isolate* isolate = info.GetIsolate();
NamedPropertyInterceptor* interceptor =
......@@ -61,7 +61,7 @@ void NamedPropertyGetter(v8::Local<v8::String> property,
info.GetReturnValue().Set(interceptor->GetNamedProperty(isolate, name));
}
void NamedPropertySetter(v8::Local<v8::String> property,
void NamedPropertySetter(v8::Local<v8::Name> property,
v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Isolate* isolate = info.GetIsolate();
......@@ -75,7 +75,7 @@ void NamedPropertySetter(v8::Local<v8::String> property,
info.GetReturnValue().Set(value);
}
void NamedPropertyQuery(v8::Local<v8::String> property,
void NamedPropertyQuery(v8::Local<v8::Name> property,
const v8::PropertyCallbackInfo<v8::Integer>& info) {
v8::Isolate* isolate = info.GetIsolate();
NamedPropertyInterceptor* interceptor =
......@@ -151,11 +151,10 @@ ObjectTemplateBuilder::ObjectTemplateBuilder(
ObjectTemplateBuilder::~ObjectTemplateBuilder() = default;
ObjectTemplateBuilder& ObjectTemplateBuilder::AddNamedPropertyInterceptor() {
template_->SetNamedPropertyHandler(&NamedPropertyGetter,
&NamedPropertySetter,
&NamedPropertyQuery,
NULL,
&NamedPropertyEnumerator);
template_->SetHandler(v8::NamedPropertyHandlerConfiguration(
&NamedPropertyGetter, &NamedPropertySetter, &NamedPropertyQuery, nullptr,
&NamedPropertyEnumerator, v8::Local<v8::Value>(),
v8::PropertyHandlerFlags::kOnlyInterceptStrings));
return *this;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment