Commit 30b56844 authored by Dmitry Gozman's avatar Dmitry Gozman Committed by Commit Bot

RenderFrameImpl: unify error page handling

This patch makes CommitFailedNavigation not use
LoadNavigationErrorPage, which is left for loading
renderer-initiated error pages. That allows us
to simplify LoadNavigationErrorPage and unify all three
renderer-initiated calls.

Bug: 855189
Change-Id: Ic56fe7b63376e0c4d92d4fb38b87e9d20aae85a5
Reviewed-on: https://chromium-review.googlesource.com/c/1338919Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612270}
parent c185420a
This diff is collapsed.
...@@ -127,7 +127,6 @@ class WebURL; ...@@ -127,7 +127,6 @@ class WebURL;
struct FramePolicy; struct FramePolicy;
struct WebContextMenuData; struct WebContextMenuData;
struct WebCursorInfo; struct WebCursorInfo;
struct WebNavigationParams;
struct WebMediaPlayerAction; struct WebMediaPlayerAction;
struct WebImeTextSpan; struct WebImeTextSpan;
struct WebScrollIntoViewParams; struct WebScrollIntoViewParams;
...@@ -160,7 +159,6 @@ class BlinkInterfaceRegistryImpl; ...@@ -160,7 +159,6 @@ class BlinkInterfaceRegistryImpl;
class CompositorDependencies; class CompositorDependencies;
class ExternalPopupMenu; class ExternalPopupMenu;
class FrameRequestBlocker; class FrameRequestBlocker;
class HistoryEntry;
class ManifestManager; class ManifestManager;
class MediaPermissionDispatcher; class MediaPermissionDispatcher;
class MediaStreamDeviceObserver; class MediaStreamDeviceObserver;
...@@ -1130,15 +1128,12 @@ class CONTENT_EXPORT RenderFrameImpl ...@@ -1130,15 +1128,12 @@ class CONTENT_EXPORT RenderFrameImpl
base::string16* result); base::string16* result);
// Loads the appropriate error page for the specified failure into the frame. // Loads the appropriate error page for the specified failure into the frame.
// |entry| is only when navigating to a history item.
void LoadNavigationErrorPage( void LoadNavigationErrorPage(
const std::string& error_html, blink::WebDocumentLoader* document_loader,
const GURL& error_url, const blink::WebURLError& error,
bool replace, const base::Optional<std::string>& error_page_content,
HistoryEntry* history_entry, bool replace_current_item,
std::unique_ptr<blink::WebNavigationParams> navigation_params, bool inherit_document_state);
std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data,
const blink::WebURLRequest* failed_request);
void HandleJavascriptExecutionResult(const base::string16& javascript, void HandleJavascriptExecutionResult(const base::string16& javascript,
int id, int id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment