Commit 31a6fb84 authored by scottmg@chromium.org's avatar scottmg@chromium.org

gn win: Always warnings as errors

R=brettw@chromium.org
BUG=393046,354261

Review URL: https://codereview.chromium.org/412423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285502 0039d316-1c4b-4281-b951-d872f2087c98
parent aa15f130
...@@ -451,13 +451,12 @@ config("runtime_library") { ...@@ -451,13 +451,12 @@ config("runtime_library") {
# Toggles between higher and lower warnings for code that is (or isn't) # Toggles between higher and lower warnings for code that is (or isn't)
# part of Chromium. # part of Chromium.
# TODO: -Werror and /WX should always be on, independent of chromium_code # TODO: -Werror should always be on, independent of chromium_code
# http://crbug.com/393046 # http://crbug.com/393046
config("chromium_code") { config("chromium_code") {
if (is_win) { if (is_win) {
cflags = [ cflags = [
"/W4", # Warning level 4. "/W4", # Warning level 4.
"/WX", # Treat warnings as errors.
] ]
} else { } else {
cflags = [ cflags = [
...@@ -566,6 +565,7 @@ config("default_warnings") { ...@@ -566,6 +565,7 @@ config("default_warnings") {
if (is_win) { if (is_win) {
# Please keep ordered and add names if you add more. # Please keep ordered and add names if you add more.
cflags = [ cflags = [
"/WX", # Treat warnings as errors.
"/wd4018", # Comparing signed and unsigned values. "/wd4018", # Comparing signed and unsigned values.
"/wd4100", # Unreferenced formal function parameter. "/wd4100", # Unreferenced formal function parameter.
"/wd4121", # Alignment of a member was sensitive to packing. "/wd4121", # Alignment of a member was sensitive to packing.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment