Commit 31f7bffa authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

bindings: Reduce the size of v8_script_runner.h

v8_script_runner.h is used in 2,800+ compilation units, and this CL
reduces its estimated expanded size from 4.06MB to 0.65MB.

Bug: 242216
Change-Id: I87f5b5ada11794eaab07c1375741dce760201605
Reviewed-on: https://chromium-review.googlesource.com/1107034Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568735}
parent 7491f7b7
...@@ -33,6 +33,7 @@ ...@@ -33,6 +33,7 @@
#include "third_party/blink/renderer/bindings/core/v8/script_controller.h" #include "third_party/blink/renderer/bindings/core/v8/script_controller.h"
#include "third_party/blink/public/web/web_settings.h" #include "third_party/blink/public/web/web_settings.h"
#include "third_party/blink/renderer/bindings/core/v8/referrer_script_info.h"
#include "third_party/blink/renderer/bindings/core/v8/script_source_code.h" #include "third_party/blink/renderer/bindings/core/v8/script_source_code.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h" #include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_code_cache.h" #include "third_party/blink/renderer/bindings/core/v8/v8_code_cache.h"
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "third_party/blink/renderer/bindings/core/v8/script_module.h" #include "third_party/blink/renderer/bindings/core/v8/script_module.h"
#include "third_party/blink/renderer/bindings/core/v8/referrer_script_info.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h" #include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_script_runner.h" #include "third_party/blink/renderer/bindings/core/v8/v8_script_runner.h"
#include "third_party/blink/renderer/core/probe/core_probes.h" #include "third_party/blink/renderer/core/probe/core_probes.h"
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "third_party/blink/public/platform/platform.h" #include "third_party/blink/public/platform/platform.h"
#include "third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h" #include "third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h"
#include "third_party/blink/public/platform/web_url_loader_mock_factory.h" #include "third_party/blink/public/platform/web_url_loader_mock_factory.h"
#include "third_party/blink/renderer/bindings/core/v8/referrer_script_info.h"
#include "third_party/blink/renderer/bindings/core/v8/script_source_code.h" #include "third_party/blink/renderer/bindings/core/v8/script_source_code.h"
#include "third_party/blink/renderer/bindings/core/v8/script_streamer_thread.h" #include "third_party/blink/renderer/bindings/core/v8/script_streamer_thread.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h" #include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h"
......
...@@ -26,20 +26,22 @@ ...@@ -26,20 +26,22 @@
#ifndef THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_SCRIPT_RUNNER_H_ #ifndef THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_SCRIPT_RUNNER_H_
#define THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_SCRIPT_RUNNER_H_ #define THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_SCRIPT_RUNNER_H_
#include "third_party/blink/renderer/bindings/core/v8/referrer_script_info.h"
#include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/core_export.h"
#include "third_party/blink/renderer/platform/bindings/script_state.h"
#include "third_party/blink/renderer/platform/bindings/v8_binding_macros.h"
#include "third_party/blink/renderer/platform/loader/fetch/access_control_status.h" #include "third_party/blink/renderer/platform/loader/fetch/access_control_status.h"
#include "third_party/blink/renderer/platform/wtf/allocator.h" #include "third_party/blink/renderer/platform/wtf/allocator.h"
#include "third_party/blink/renderer/platform/wtf/text/text_position.h" #include "third_party/blink/renderer/platform/wtf/forward.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
#include "v8/include/v8.h" #include "v8/include/v8.h"
namespace WTF {
class TextPosition;
}
namespace blink { namespace blink {
class ExecutionContext; class ExecutionContext;
class ReferrerScriptInfo;
class ScriptSourceCode; class ScriptSourceCode;
class ScriptState;
class CORE_EXPORT V8ScriptRunner final { class CORE_EXPORT V8ScriptRunner final {
STATIC_ONLY(V8ScriptRunner); STATIC_ONLY(V8ScriptRunner);
...@@ -58,7 +60,7 @@ class CORE_EXPORT V8ScriptRunner final { ...@@ -58,7 +60,7 @@ class CORE_EXPORT V8ScriptRunner final {
const String& source, const String& source,
const String& file_name, const String& file_name,
AccessControlStatus, AccessControlStatus,
const TextPosition&, const WTF::TextPosition&,
const ReferrerScriptInfo&); const ReferrerScriptInfo&);
static v8::MaybeLocal<v8::Value> RunCompiledScript(v8::Isolate*, static v8::MaybeLocal<v8::Value> RunCompiledScript(v8::Isolate*,
v8::Local<v8::Script>, v8::Local<v8::Script>,
...@@ -93,7 +95,7 @@ class CORE_EXPORT V8ScriptRunner final { ...@@ -93,7 +95,7 @@ class CORE_EXPORT V8ScriptRunner final {
static void ReportExceptionForModule(v8::Isolate*, static void ReportExceptionForModule(v8::Isolate*,
v8::Local<v8::Value> exception, v8::Local<v8::Value> exception,
const String& file_name, const String& file_name,
const TextPosition&); const WTF::TextPosition&);
// Calls a function on the V8 extras binding object. // Calls a function on the V8 extras binding object.
template <size_t N> template <size_t N>
......
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include "third_party/blink/public/platform/platform.h" #include "third_party/blink/public/platform/platform.h"
#include "third_party/blink/renderer/bindings/core/v8/initialize_v8_extras_binding.h" #include "third_party/blink/renderer/bindings/core/v8/initialize_v8_extras_binding.h"
#include "third_party/blink/renderer/bindings/core/v8/referrer_script_info.h"
#include "third_party/blink/renderer/bindings/core/v8/script_controller.h" #include "third_party/blink/renderer/bindings/core/v8/script_controller.h"
#include "third_party/blink/renderer/bindings/core/v8/script_source_code.h" #include "third_party/blink/renderer/bindings/core/v8/script_source_code.h"
#include "third_party/blink/renderer/bindings/core/v8/script_value.h" #include "third_party/blink/renderer/bindings/core/v8/script_value.h"
......
...@@ -28,6 +28,7 @@ class DOMArrayBufferView; ...@@ -28,6 +28,7 @@ class DOMArrayBufferView;
class PresentationController; class PresentationController;
class PresentationReceiver; class PresentationReceiver;
class PresentationRequest; class PresentationRequest;
class WebString;
class PresentationConnection : public EventTargetWithInlineData, class PresentationConnection : public EventTargetWithInlineData,
public ContextLifecycleObserver, public ContextLifecycleObserver,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment