Migrate off BrowserThread::DeleteSoon in /content/browser/renderer_host/media

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=jrummell@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I4bf2d6caee1e3a77f740d93a533cf021c68d6a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895645
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712872}

content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc

@@ -196,7 +196,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest, AuthorizeDefaultDevice_Ok) {
           base::UnguessableToken(), kDefaultDeviceId, listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -218,7 +218,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           base::UnguessableToken(), kEmptyDeviceId, listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -254,7 +254,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           base::UnguessableToken(), hashed_id, listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -288,7 +288,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           base::UnguessableToken(), hashed_id, listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -313,7 +313,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest, AuthorizeInvalidDeviceId_NotFound) {
   // It is possible to request an invalid device id from JS APIs,
   // so we don't want to crash the renderer for this.
   EXPECT_EQ(process()->bad_msg_count(), 0);
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -346,7 +346,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
   SyncWithAllThreads();
 
   EXPECT_EQ(process()->bad_msg_count(), 0);
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -369,7 +369,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           base::UnguessableToken::Create(), std::string(), listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }
 
@@ -417,7 +417,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           base::UnguessableToken(), hashed_id, listener.Get()));
 
   SyncWithAllThreads();
-  BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
+  base::DeleteSoon(FROM_HERE, {BrowserThread::IO}, handler.release());
   SyncWithAllThreads();
 }