Commit 32d446c0 authored by Aaron Leventhal's avatar Aaron Leventhal Committed by Chromium LUCI CQ

Comment out DCHECK for now

R=chrishtr@chromium.org

Bug: 1166296
Change-Id: I26d9e83ce62d9b28a610cf7e747cc4403af3c2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633027
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844278}
parent 826ce66f
...@@ -469,17 +469,15 @@ String Element::innerText() { ...@@ -469,17 +469,15 @@ String Element::innerText() {
// Used for callers that must ensure no document lifecycle rewind. // Used for callers that must ensure no document lifecycle rewind.
String Element::GetInnerTextWithoutUpdate() { String Element::GetInnerTextWithoutUpdate() {
// TODO(https:://crbug.com/1165850) Layout should always be clean here, but // TODO(https:://crbug.com/1165850 https:://crbug.com/1166296) Layout should
// the lifecycle does not report the correctly updated value unless servicing // always be clean here, but the lifecycle does not report the correctly
// animations. Fix the UpdateStyleAndLayout() to correctly advance the // updated value unless servicing animations. Fix the UpdateStyleAndLayout()
// lifecycle, and then update the following DCHECK to always require clean // to correctly advance the lifecycle, and then update the following DCHECK to
// layout in active documents. // always require clean layout in active documents.
DCHECK(!GetDocument().IsActive() || !GetDocument().GetPage() || // DCHECK(!GetDocument().IsActive() || !GetDocument().GetPage() ||
!GetDocument().GetPage()->Animator().IsServicingAnimations() || // GetDocument().Lifecycle().GetState() >=
GetDocument().Lifecycle().GetState() >= // DocumentLifecycle::kLayoutClean)
DocumentLifecycle::kLayoutClean) // << "Layout must be clean when GetInnerTextWithoutUpdate() is called.";
<< "If GetInnerTextWithoutUpdate() is called while servicing animations, "
"then layout must be clean.";
return ElementInnerTextCollector().RunOn(*this); return ElementInnerTextCollector().RunOn(*this);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment