Commit 33086b80 authored by Jesse Schettler's avatar Jesse Schettler Committed by Commit Bot

Revert "arc: Add logging to investigate ARC print failures"

This reverts commit f64a6c0a.

Reason for revert: Logging no longer needed.

Original change's description:
> arc: Add logging to investigate ARC print failures
> 
> Print preview occasionally fails in the arc.Print tast test. Add logging
> to investigate these failures.
> 
> Bug: b:152251595
> Change-Id: I5b8b18213ec8c7fc2a56646c65dfe5262b86f677
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144456
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Jesse Schettler <jschettler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758262}

TBR=thestig@chromium.org,jschettler@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:152251595
Change-Id: Iaaa10289a1ba47b7415b1fa820702d9791ad19ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150817Reviewed-by: default avatarJesse Schettler <jschettler@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759365}
parent 820e29ad
......@@ -146,8 +146,6 @@ base::ReadOnlySharedMemoryRegion ReadPreviewDocument(
base::PlatformFile platform_file;
if (mojo::UnwrapPlatformFile(std::move(preview_document), &platform_file) !=
MOJO_RESULT_OK) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Failed to unwrap platform file.";
return base::ReadOnlySharedMemoryRegion();
}
......@@ -263,8 +261,6 @@ void PrintSessionImpl::CreatePreviewDocument(
mojom::PrintDocumentRequestPtr request =
PrintDocumentRequestFromJobSettings(job_settings);
if (!request || !request->attributes) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Failed to create print document request.";
std::move(callback).Run(base::ReadOnlySharedMemoryRegion());
return;
}
......@@ -284,8 +280,6 @@ void PrintSessionImpl::OnPreviewDocumentCreated(
int64_t data_size) {
if (data_size < kMinimumPdfSize ||
!base::IsValueInRangeForNumericType<size_t>(data_size)) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Invalid data size for preview document: " << data_size;
std::move(callback).Run(base::ReadOnlySharedMemoryRegion());
return;
}
......@@ -304,8 +298,6 @@ void PrintSessionImpl::OnPreviewDocumentRead(
CreatePreviewDocumentCallback callback,
base::ReadOnlySharedMemoryRegion preview_document_region) {
if (!preview_document_region.IsValid()) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Invalid memory region for preview document.";
std::move(callback).Run(std::move(preview_document_region));
return;
}
......
......@@ -1646,11 +1646,8 @@ bool PrintRenderFrameHelper::ProcessPreviewDocument(
base::ReadOnlySharedMemoryMapping preview_document_mapping =
preview_document_region.Map();
if (!preview_document_mapping.IsValid()) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Invalid memory region for preview document.";
if (!preview_document_mapping.IsValid())
return false;
}
CHECK(print_preview_context_.metafile()->InitFromData(
preview_document_mapping.GetMemoryAsSpan<const uint8_t>()));
......@@ -1659,11 +1656,8 @@ bool PrintRenderFrameHelper::ProcessPreviewDocument(
return false;
print_preview_context_.AllPagesRendered();
if (!FinalizePrintReadyDocument()) {
// TODO(jschettler): Remove logging when finished investigating b/152251595.
LOG(ERROR) << "Failed to finalize print-ready document.";
if (!FinalizePrintReadyDocument())
return false;
}
print_preview_context_.Finished();
return true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment