Commit 336973d7 authored by Ben Pastene's avatar Ben Pastene Committed by Commit Bot

Fix MB config expectations for 'phased' builders.

Some builders have a different set of GN args used within a single
build. These phased builders didn't have very readable expectations.

This should fix that.

Bug: 1117577
Change-Id: I965081c221d3508bb6988d8a1b45f0f387384537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458207Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814865}
parent 126058fb
......@@ -713,10 +713,12 @@ class MetaBuildWrapper(object):
if not config:
continue
if isinstance(config, dict):
args = {
k: FlattenConfig(self.configs, self.mixins, v)['gn_args']
for k, v in config.items()
}
# This is a 'phased' builder. Each key in the config is a different
# phase of the builder.
args = {}
for k, v in config.items():
args[k] = gn_helpers.FromGNArgs(
FlattenConfig(self.configs, self.mixins, v)['gn_args'])
elif config.startswith('//'):
args = config
else:
......
......@@ -36,8 +36,17 @@
}
},
"Deterministic Linux (dbg)": {
"goma": "is_debug=true is_component_build=true use_goma=true symbol_level=1",
"local": "is_debug=true is_component_build=true symbol_level=1"
"goma": {
"is_component_build": true,
"is_debug": true,
"symbol_level": 1,
"use_goma": true
},
"local": {
"is_component_build": true,
"is_debug": true,
"symbol_level": 1
}
},
"Fuchsia ARM64": {
"gn_args": {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment