Commit 33e3f1e8 authored by raymes@chromium.org's avatar raymes@chromium.org

Re-enabled PPAPI crash url for non-windows platforms.

When this is enabled for windows, we stop getting crash reports.
See https://code.google.com/p/chromium/issues/detail?id=135480

BUG=135480
TEST=


Review URL: https://chromiumcodereview.appspot.com/10736039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146199 0039d316-1c4b-4281-b951-d872f2087c98
parent b3be9aa9
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/message_loop.h" #include "base/message_loop.h"
#include "base/time.h" #include "base/time.h"
#include "build/build_config.h"
#include "ppapi/c/dev/ppb_font_dev.h" #include "ppapi/c/dev/ppb_font_dev.h"
#include "ppapi/c/dev/ppb_var_deprecated.h" #include "ppapi/c/dev/ppb_var_deprecated.h"
#include "ppapi/c/pp_errors.h" #include "ppapi/c/pp_errors.h"
...@@ -312,10 +313,12 @@ PP_Bool PPB_Flash_Proxy::SetCrashData(PP_Instance instance, ...@@ -312,10 +313,12 @@ PP_Bool PPB_Flash_Proxy::SetCrashData(PP_Instance instance,
PP_Var value) { PP_Var value) {
switch (key) { switch (key) {
case PP_FLASHCRASHKEY_URL: case PP_FLASHCRASHKEY_URL:
// TODO(raymes): This may be breaking crash reporting, see: #if defined(OS_WIN)
// TODO(raymes): This may be breaking crash reporting on Windows, see:
// See https://code.google.com/p/chromium/issues/detail?id=135480. // See https://code.google.com/p/chromium/issues/detail?id=135480.
// Disable temporarily. // Disable temporarily.
return PP_FALSE; return PP_FALSE;
#endif
StringVar *url_string_var(StringVar::FromPPVar(value)); StringVar *url_string_var(StringVar::FromPPVar(value));
if (!url_string_var) if (!url_string_var)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment