Commit 34324a5f authored by rbpotter's avatar rbpotter Committed by Chromium LUCI CQ

Print Preview: Fix some polish issues with icon alignment

Bug: 1156918
Change-Id: I0d3fcd231a8896aee4d3869cc1bb7b080e1558f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581022
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835885}
parent bf36fb18
...@@ -13,10 +13,9 @@ ...@@ -13,10 +13,9 @@
.throbber-container { .throbber-container {
display: flex; display: flex;
margin-inline-start: 14px; margin-inline-start:
calc((var(--search-icon-size) - var(--throbber-size))/2);
min-height: var(--destination-item-height); min-height: var(--destination-item-height);
padding-inline-end: 16px;
padding-inline-start: calc(10/13 * 1em);
} }
.throbber { .throbber {
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
min-height: var(--destination-item-height); min-height: var(--destination-item-height);
opacity: .87; opacity: .87;
padding-inline-end: 2px; padding-inline-end: 2px;
padding-inline-start: 14px; padding-inline-start: 0;
vertical-align: middle; vertical-align: middle;
} }
...@@ -15,19 +15,24 @@ ...@@ -15,19 +15,24 @@
align-items: center; align-items: center;
color: var(--cr-secondary-text-color); color: var(--cr-secondary-text-color);
font-size: calc(10/12 * 1em); font-size: calc(10/12 * 1em);
margin-inline-start: 1em;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
vertical-align: middle; vertical-align: middle;
white-space: nowrap; white-space: nowrap;
} }
:host > span {
margin-inline-start: 1em;
}
iron-icon { iron-icon {
--icon-margin: calc((var(--search-icon-size) - var(--iron-icon-width))/2);
fill: var(--google-grey-600); fill: var(--google-grey-600);
flex: 0; flex: 0;
height: 20px; height: var(--iron-icon-height);
margin-inline-end: 12px; margin-inline-end: var(--icon-margin);
min-width: 20px; margin-inline-start: var(--icon-margin);
min-width: var(--iron-icon-width);
transition: opacity 150ms; transition: opacity 150ms;
} }
...@@ -37,10 +42,12 @@ ...@@ -37,10 +42,12 @@
} }
} }
.name { :host .name {
color: var(--cr-primary-text-color); color: var(--cr-primary-text-color);
font-size: 1em; font-size: 1em;
margin-inline-start: 0; margin-inline-start: 0;
/* Matches cr-input-padding-start */
padding-inline-start: 8px;
} }
.extension-controlled-indicator { .extension-controlled-indicator {
...@@ -48,6 +55,7 @@ ...@@ -48,6 +55,7 @@
flex: 1; flex: 1;
justify-content: flex-end; justify-content: flex-end;
min-width: 150px; min-width: 150px;
padding-inline-end: 8px;
} }
.extension-icon { .extension-icon {
......
...@@ -15,8 +15,8 @@ ...@@ -15,8 +15,8 @@
} }
#icon { #icon {
height: 30px; height: var(--search-icon-size);
width: 30px; width: var(--search-icon-size);
} }
#clearSearch { #clearSearch {
......
...@@ -19,6 +19,8 @@ ...@@ -19,6 +19,8 @@
--iron-icon-fill-color: var(--google-grey-refresh-700); --iron-icon-fill-color: var(--google-grey-refresh-700);
--iron-icon-height: var(--cr-icon-size); --iron-icon-height: var(--cr-icon-size);
--iron-icon-width: var(--cr-icon-size); --iron-icon-width: var(--cr-icon-size);
--search-icon-size: 32px;
--throbber-size: 16px;
} }
@media (prefers-color-scheme: dark) { @media (prefers-color-scheme: dark) {
......
...@@ -3,8 +3,8 @@ ...@@ -3,8 +3,8 @@
.throbber { .throbber {
background: url(chrome://resources/images/throbber_small.svg) no-repeat; background: url(chrome://resources/images/throbber_small.svg) no-repeat;
display: inline-block; display: inline-block;
height: 16px; height: var(--throbber-size);
width: 16px; width: var(--throbber-size);
} }
</style> </style>
</template> </template>
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
import 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; import 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
import './print_preview_vars_css.js';
const template = document.createElement('template'); const template = document.createElement('template');
template.innerHTML = ` template.innerHTML = `
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment