Commit 34a8017b authored by Wolfgang Beyer's avatar Wolfgang Beyer Committed by Chromium LUCI CQ

[DevTools] Update tests after landing DevTools frontend changes

Frontend CL: https://crrev.com/c/2584978
Disable tests CLs:
https://crrev.com/c/2584848
https://crrev.com/c/2592797

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: I200074600b3e82404bc42694defa6a407ded6e73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587035
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: default avatarPaul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842945}
parent 70a99708
...@@ -5658,13 +5658,6 @@ crbug.com/1042877 http/tests/security/mixedContent/strict-mode-via-pref-image-bl ...@@ -5658,13 +5658,6 @@ crbug.com/1042877 http/tests/security/mixedContent/strict-mode-via-pref-image-bl
# Mixed content autoupgrades cause test to fail because test relied on http subresources to test a different origin, needs to be changed to not rely on HTTP URLs. # Mixed content autoupgrades cause test to fail because test relied on http subresources to test a different origin, needs to be changed to not rely on HTTP URLs.
crbug.com/1042877 http/tests/security/img-crossorigin-redirect-credentials.https.html [ Failure ] crbug.com/1042877 http/tests/security/img-crossorigin-redirect-credentials.https.html [ Failure ]
# Temporarily disable tests to land DevTools frontend changes
crbug.com/1152082 http/tests/devtools/bindings/blackboxed-sourcemap-detach.js [ Pass Failure Timeout ]
crbug.com/1152082 http/tests/devtools/console/console-linkify-message-location.js [ Pass Failure Timeout ]
crbug.com/1152082 http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-by-source-code.js [ Pass Failure Timeout ]
crbug.com/1152082 http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-patterns.js [ Pass Failure Timeout ]
crbug.com/1152082 http/tests/devtools/tracing/timeline-js/timeline-js-ignore-list.js [ Pass Failure Timeout ]
# Sheriff 2020-10-09 # Sheriff 2020-10-09
crbug.com/1136687 external/wpt/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture.html [ Pass Failure ] crbug.com/1136687 external/wpt/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture.html [ Pass Failure ]
crbug.com/1136726 [ Linux ] virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [ Failure ] crbug.com/1136726 [ Linux ] virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [ Failure ]
......
Tests that blackboxed sourcemaps properly detach on reload crbug.com/888688 Tests that ignore-listed sourcemaps properly detach on reload crbug.com/888688
Evaluating script with source map Evaluating script with source map
Message count: 1 Message count: 1
Page reloaded. Page reloaded.
......
...@@ -4,12 +4,12 @@ ...@@ -4,12 +4,12 @@
(async function() { (async function() {
await TestRunner.loadModule('console_test_runner'); await TestRunner.loadModule('console_test_runner');
TestRunner.addResult(`Tests that blackboxed sourcemaps properly detach on reload crbug.com/888688`); TestRunner.addResult(`Tests that ignore-listed sourcemaps properly detach on reload crbug.com/888688`);
var content = var content =
`console.log(1); `console.log(1);
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZXZhbC1pbi5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbImV2YWwtaW4iXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsT0FBTyxDQUFDLEdBQUcsQ0FBQyxDQUFDLENBQUMsQ0FBQyIsInNvdXJjZXNDb250ZW50IjpbImNvbnNvbGUubG9nKDEpOyJdfQ==`; //# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZXZhbC1pbi5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbImV2YWwtaW4iXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsT0FBTyxDQUFDLEdBQUcsQ0FBQyxDQUFDLENBQUMsQ0FBQyIsInNvdXJjZXNDb250ZW50IjpbImNvbnNvbGUubG9nKDEpOyJdfQ==`;
TestRunner.addSniffer(Bindings.BlackboxManager.prototype, '_patternChangeFinishedForTests', step1); TestRunner.addSniffer(Bindings.IgnoreListManager.prototype, '_patternChangeFinishedForTests', step1);
var frameworkRegexString = '.*'; var frameworkRegexString = '.*';
Common.settingForTest('skipStackFramesPattern').set('.*'); Common.settingForTest('skipStackFramesPattern').set('.*');
......
Test that console.log() would linkify its location in respect with blackboxing. Test that console.log() would linkify its location in respect with ignore-listing.
foo.js:13 foo.js:13
boo.js:20 boo.js:20
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
(async function() { (async function() {
TestRunner.addResult(`Test that console.log() would linkify its location in respect with blackboxing.\n`); TestRunner.addResult(`Test that console.log() would linkify its location in respect with ignore-listing.\n`);
await TestRunner.loadModule('console_test_runner'); await TestRunner.loadModule('console_test_runner');
await TestRunner.showPanel('console'); await TestRunner.showPanel('console');
...@@ -27,21 +27,21 @@ ...@@ -27,21 +27,21 @@
async function step1() { async function step1() {
await dumpConsoleMessageURLs(); await dumpConsoleMessageURLs();
TestRunner.addSniffer(Bindings.BlackboxManager.prototype, '_patternChangeFinishedForTests', step2); TestRunner.addSniffer(Bindings.IgnoreListManager.prototype, '_patternChangeFinishedForTests', step2);
var frameworkRegexString = 'foo\\.js'; var frameworkRegexString = 'foo\\.js';
Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString); Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString);
} }
async function step2() { async function step2() {
await dumpConsoleMessageURLs(); await dumpConsoleMessageURLs();
TestRunner.addSniffer(Bindings.BlackboxManager.prototype, '_patternChangeFinishedForTests', step3); TestRunner.addSniffer(Bindings.IgnoreListManager.prototype, '_patternChangeFinishedForTests', step3);
var frameworkRegexString = 'foo\\.js|boo\\.js'; var frameworkRegexString = 'foo\\.js|boo\\.js';
Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString); Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString);
} }
async function step3() { async function step3() {
await dumpConsoleMessageURLs(); await dumpConsoleMessageURLs();
TestRunner.addSniffer(Bindings.BlackboxManager.prototype, '_patternChangeFinishedForTests', step4); TestRunner.addSniffer(Bindings.IgnoreListManager.prototype, '_patternChangeFinishedForTests', step4);
var frameworkRegexString = ''; var frameworkRegexString = '';
Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString); Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString);
} }
......
Tests provisional blackboxing. Tests provisional ignore-listing.
Set timer for test function. Set timer for test function.
Call stack: Call stack:
0) testFunction (frameworks-blackbox-by-source-code.js:12) 0) testFunction (frameworks-ignore-list-by-source-code.js:12)
[setTimeout] [setTimeout]
0) scheduleTestFunction <omitted> 0) scheduleTestFunction <omitted>
<... skipped remaining frames ...> <... skipped remaining frames ...>
...@@ -10,7 +10,7 @@ Call stack: ...@@ -10,7 +10,7 @@ Call stack:
Executing StepInto... Executing StepInto...
Executing StepInto... Executing StepInto...
Call stack: Call stack:
0) testFunction (frameworks-blackbox-by-source-code.js:14) 0) testFunction (frameworks-ignore-list-by-source-code.js:14)
[setTimeout] [setTimeout]
0) scheduleTestFunction <omitted> 0) scheduleTestFunction <omitted>
<... skipped remaining frames ...> <... skipped remaining frames ...>
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
(async function() { (async function() {
TestRunner.addResult(`Tests provisional blackboxing.\n`); TestRunner.addResult(`Tests provisional ignore-listing.\n`);
await TestRunner.loadModule('sources_test_runner'); await TestRunner.loadModule('sources_test_runner');
await TestRunner.showPanel('sources'); await TestRunner.showPanel('sources');
await TestRunner.evaluateInPagePromise(` await TestRunner.evaluateInPagePromise(`
...@@ -12,13 +12,13 @@ ...@@ -12,13 +12,13 @@
debugger; debugger;
eval("239;//# sourceURL=framework.js"); eval("239;//# sourceURL=framework.js");
} }
//# sourceURL=frameworks-blackbox-by-source-code.js //# sourceURL=frameworks-ignore-list-by-source-code.js
`); `);
SourcesTestRunner.startDebuggerTest(step1, true); SourcesTestRunner.startDebuggerTest(step1, true);
function step1() { function step1() {
TestRunner.addSniffer(Bindings.BlackboxManager.prototype, '_patternChangeFinishedForTests', step2); TestRunner.addSniffer(Bindings.IgnoreListManager.prototype, '_patternChangeFinishedForTests', step2);
var frameworkRegexString = '^framework\\.js$'; var frameworkRegexString = '^framework\\.js$';
Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString); Common.settingForTest('skipStackFramesPattern').set(frameworkRegexString);
} }
......
Tests framework blackbox patterns for various URLs. Tests framework ignore list patterns for various URLs.
Testing "http://www.example.com/foo/jquery-1.7-min.js" Testing "http://www.example.com/foo/jquery-1.7-min.js"
Testing "https://www.example.com/jquery.js?version=1.7" Testing "https://www.example.com/jquery.js?version=1.7"
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
(async function() { (async function() {
TestRunner.addResult(`Tests framework blackbox patterns for various URLs.\n`); TestRunner.addResult(`Tests framework ignore list patterns for various URLs.\n`);
await TestRunner.showPanel('sources'); await TestRunner.showPanel('sources');
var testCases = [ var testCases = [
...@@ -34,7 +34,7 @@ ...@@ -34,7 +34,7 @@
for (var i = 0; i < testCases.length; i += 2) { for (var i = 0; i < testCases.length; i += 2) {
var url = testCases[i]; var url = testCases[i];
TestRunner.addResult('Testing "' + url + '"'); TestRunner.addResult('Testing "' + url + '"');
var regexValue = Bindings.blackboxManager._urlToRegExpString(url); var regexValue = Bindings.ignoreListManager._urlToRegExpString(url);
TestRunner.assertEquals(testCases[i + 1], regexValue); TestRunner.assertEquals(testCases[i + 1], regexValue);
if (!regexValue) if (!regexValue)
continue; continue;
......
...@@ -219,11 +219,11 @@ ...@@ -219,11 +219,11 @@
dataProvider.setModel(PerformanceTestRunner.createPerformanceModelWithEvents(rawTraceEvents)); dataProvider.setModel(PerformanceTestRunner.createPerformanceModelWithEvents(rawTraceEvents));
TestRunner.addResult('\nIgnore listed url: lib_script.js'); TestRunner.addResult('\nIgnore listed url: lib_script.js');
Bindings.blackboxManager._blackboxURL('lib_script.js'); Bindings.ignoreListManager._ignoreListURL('lib_script.js');
printTimelineData(dataProvider); printTimelineData(dataProvider);
TestRunner.addResult('\nUnignored url: lib_script.js'); TestRunner.addResult('\nUnignored url: lib_script.js');
Bindings.blackboxManager._unblackboxURL('lib_script.js'); Bindings.ignoreListManager._unIgnoreListURL('lib_script.js');
printTimelineData(dataProvider); printTimelineData(dataProvider);
TestRunner.completeTest(); TestRunner.completeTest();
})(); })();
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment