Commit 34ea5e4b authored by Vikas Soni's avatar Vikas Soni Committed by Commit Bot

Revert "Adding CHECK macro to debug crash."

This reverts commit bafb8331.

Reverting the patch since the CHECK macro is
no longer needed now.

Original change's description:
> Adding CHECK macro to debug crash.
>
> Moving a DCHCEK to CHECK and adding a new CHECK macro to debug crash
> which are hard to reproduce on local devices. This CHECK will soon
> be moved back to DCHECK.
>
> Bug: 892354
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I44e237db73cec5259b90bb312e7940b41553d332
> Reviewed-on: https://chromium-review.googlesource.com/c/1282104
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599885}

TBR=piman@chromium.org,vikassoni@chromium.org

Bug: 892354
Change-Id: Id75912831cb8087976b481feb51293d941263da1
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1295314
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601835}
parent 75a712c6
...@@ -524,11 +524,7 @@ void GPUTimer::Reset() { ...@@ -524,11 +524,7 @@ void GPUTimer::Reset() {
} }
void GPUTimer::QueryTimeStamp() { void GPUTimer::QueryTimeStamp() {
// TODO(vikassoni): Adding CHECK instead of DCHECK temporarily to debug DCHECK(gpu_timing_client_->gpu_timing_);
// a crash - http://crbug.com/892354. This is only meant for canary and will
// be removed in few days.
CHECK(gpu_timing_client_);
CHECK(gpu_timing_client_->gpu_timing_);
Reset(); Reset();
time_stamp_result_ = gpu_timing_client_->gpu_timing_->DoTimeStampQuery(); time_stamp_result_ = gpu_timing_client_->gpu_timing_->DoTimeStampQuery();
timer_state_ = kTimerState_WaitingForResult; timer_state_ = kTimerState_WaitingForResult;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment