Commit 353d388d authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Delete old Finch experiment about password smart bubble.

The experiment was launched with the threshold '3'.

Bug: 552010
Change-Id: I6bf72aa48715a15c021c907c1a6fd3f0de80a26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880042Reviewed-by: default avatarNik Bhagat <nikunjb@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710286}
parent 31e773fd
...@@ -180,17 +180,6 @@ void TestManagePasswordsUIController::HidePasswordBubble() { ...@@ -180,17 +180,6 @@ void TestManagePasswordsUIController::HidePasswordBubble() {
} }
} }
void CreateSmartBubbleFieldTrial() {
using password_bubble_experiment::kSmartBubbleExperimentName;
using password_bubble_experiment::kSmartBubbleThresholdParam;
std::map<std::string, std::string> params;
params[kSmartBubbleThresholdParam] =
base::NumberToString(kGreatDissmisalCount / 2);
variations::AssociateVariationParams(kSmartBubbleExperimentName, "A", params);
ASSERT_TRUE(
base::FieldTrialList::CreateFieldTrial(kSmartBubbleExperimentName, "A"));
}
} // namespace } // namespace
class ManagePasswordsUIControllerTest : public ChromeRenderViewHostTestHarness { class ManagePasswordsUIControllerTest : public ChromeRenderViewHostTestHarness {
...@@ -428,7 +417,6 @@ TEST_F(ManagePasswordsUIControllerTest, BlacklistedFormPasswordSubmitted) { ...@@ -428,7 +417,6 @@ TEST_F(ManagePasswordsUIControllerTest, BlacklistedFormPasswordSubmitted) {
} }
TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) { TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) {
CreateSmartBubbleFieldTrial();
std::unique_ptr<PasswordFormManager> test_form_manager(CreateFormManager()); std::unique_ptr<PasswordFormManager> test_form_manager(CreateFormManager());
std::vector<password_manager::InteractionsStats> stats(1); std::vector<password_manager::InteractionsStats> stats(1);
stats[0].origin_domain = test_local_form().origin.GetOrigin(); stats[0].origin_domain = test_local_form().origin.GetOrigin();
...@@ -447,7 +435,6 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) { ...@@ -447,7 +435,6 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) {
} }
TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleNotSuppressed) { TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleNotSuppressed) {
CreateSmartBubbleFieldTrial();
std::unique_ptr<PasswordFormManager> test_form_manager(CreateFormManager()); std::unique_ptr<PasswordFormManager> test_form_manager(CreateFormManager());
std::vector<password_manager::InteractionsStats> stats(1); std::vector<password_manager::InteractionsStats> stats(1);
stats[0].origin_domain = test_local_form().origin.GetOrigin(); stats[0].origin_domain = test_local_form().origin.GetOrigin();
......
...@@ -19,9 +19,6 @@ ...@@ -19,9 +19,6 @@
namespace password_bubble_experiment { namespace password_bubble_experiment {
const char kSmartBubbleExperimentName[] = "PasswordSmartBubble";
const char kSmartBubbleThresholdParam[] = "dismissal_count";
void RegisterPrefs(PrefRegistrySimple* registry) { void RegisterPrefs(PrefRegistrySimple* registry) {
registry->RegisterBooleanPref( registry->RegisterBooleanPref(
password_manager::prefs::kWasSignInPasswordPromoClicked, false); password_manager::prefs::kWasSignInPasswordPromoClicked, false);
...@@ -34,11 +31,7 @@ void RegisterPrefs(PrefRegistrySimple* registry) { ...@@ -34,11 +31,7 @@ void RegisterPrefs(PrefRegistrySimple* registry) {
} }
int GetSmartBubbleDismissalThreshold() { int GetSmartBubbleDismissalThreshold() {
std::string param = variations::GetVariationParamValue( return 3;
kSmartBubbleExperimentName, kSmartBubbleThresholdParam);
int threshold = 0;
// 3 is the default magic number that proved to show the best result.
return base::StringToInt(param, &threshold) ? threshold : 3;
} }
bool IsSmartLockUser(const syncer::SyncService* sync_service) { bool IsSmartLockUser(const syncer::SyncService* sync_service) {
......
...@@ -14,9 +14,6 @@ class SyncService; ...@@ -14,9 +14,6 @@ class SyncService;
namespace password_bubble_experiment { namespace password_bubble_experiment {
extern const char kSmartBubbleExperimentName[];
extern const char kSmartBubbleThresholdParam[];
// Registers prefs which controls appearance of the first run experience for the // Registers prefs which controls appearance of the first run experience for the
// Smart Lock UI, namely was first run experience shown for save prompt or auto // Smart Lock UI, namely was first run experience shown for save prompt or auto
// sign-in prompt. // sign-in prompt.
......
...@@ -4398,24 +4398,6 @@ ...@@ -4398,24 +4398,6 @@
] ]
} }
], ],
"PasswordSmartBubble": [
{
"platforms": [
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "3-Times",
"params": {
"dismissal_count": "3"
}
}
]
}
],
"PauseBrowserInitiatedHeavyTrafficForP2P": [ "PauseBrowserInitiatedHeavyTrafficForP2P": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment