Commit 35c44df9 authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Revert "Increase android32_ndk_api_level 16 -> 21"

This reverts commit 1d5cb6af.

Reason for revert: Breaking v8 kitkat bots

Original change's description:
> Increase android32_ndk_api_level 16 -> 21
> 
> We only support 21+, so we should build for it.
> 
> Bug: 1116198
> Change-Id: I552a946b245de0f54485ea985e08b53b92186bb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367984
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804976}

TBR=agrieve@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1116198, 1126469
Change-Id: Ia59936b975b6a17ec102fea02b9e86ba15de7b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401268Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805510}
parent a1eb30c9
...@@ -49,6 +49,12 @@ if (is_android || is_chromeos) { ...@@ -49,6 +49,12 @@ if (is_android || is_chromeos) {
# not explicitly set it. # not explicitly set it.
default_min_sdk_version = 21 default_min_sdk_version = 21
# Android API level for 32 bits platforms
android32_ndk_api_level = 16
# Android API level for 64 bits platforms
android64_ndk_api_level = 21
# [WIP] Allows devs to achieve much faster edit-build-install cycles. # [WIP] Allows devs to achieve much faster edit-build-install cycles.
# Currently only works for ChromeModern apks due to incremental install. # Currently only works for ChromeModern apks due to incremental install.
# This needs to be in a separate declare_args as it determines some of the # This needs to be in a separate declare_args as it determines some of the
...@@ -56,18 +62,6 @@ if (is_android || is_chromeos) { ...@@ -56,18 +62,6 @@ if (is_android || is_chromeos) {
android_fast_local_dev = false android_fast_local_dev = false
} }
declare_args() {
# Android API level for 32 bits platforms
android32_ndk_api_level = default_min_sdk_version
# Android API level for 64 bits platforms
if (default_min_sdk_version < 21) {
android64_ndk_api_level = 21
} else {
android64_ndk_api_level = default_min_sdk_version
}
}
if (enable_chrome_android_internal) { if (enable_chrome_android_internal) {
import("//clank/config.gni") import("//clank/config.gni")
} else { } else {
......
...@@ -12,16 +12,10 @@ import("//build/config/sanitizers/sanitizers.gni") ...@@ -12,16 +12,10 @@ import("//build/config/sanitizers/sanitizers.gni")
if (current_toolchain == default_toolchain && if (current_toolchain == default_toolchain &&
(!is_debug && !using_sanitizer && proprietary_codecs)) { (!is_debug && !using_sanitizer && proprietary_codecs)) {
# Define expectations only for target_cpu covered by trybots. # Define expectations only for target_cpu covered by trybots.
if (current_cpu == "arm") {
# Currently static_initializers come from: # Currently static_initializers come from:
# * iostream.cpp std::__1::ios_base::Init::Init() # * iostream.cpp
# * token.cc: (empty initializer list) # * token.cc
# * base_logging.cc: (empty initializer list) (//v8/src/base/logging.cc) if (target_cpu == "arm" || target_cpu == "arm64") {
expected_static_initializer_count = 3
} else if (current_cpu == "arm64") {
# Currently static_initializers come from:
# * iostream.cpp std::__1::ios_base::Init::Init()
# * token.cc: (empty initializer list)
expected_static_initializer_count = 2 expected_static_initializer_count = 2
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment