Commit 36091b45 authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Revert "Re-add EyeDropperBrowserTests on FYI bot"

This reverts commit fbdd1097.

Reason for revert: Fails consistently on Mac10.13 Tests (dbg)
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20278

Original change's description:
> Re-add EyeDropperBrowserTests on FYI bot
>
> Can't repro the flaky test locally. Re-adding to FYI bot for further
> debugging and remain disabled for CI/CQ bot.
>
> Bug: 1131319
> Change-Id: Id0efb7067480d668dd7caad1cbb6763cb0a1ae84
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446025
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Sven Zheng <svenzheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#814349}

TBR=ellyjones@chromium.org,martiniss@chromium.org,svenzheng@chromium.org

Change-Id: I6d90db5e79679597dc7cadd42adb7491df196891
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455606Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814615}
parent a469b859
......@@ -67,7 +67,9 @@ class EyeDropperBrowserTest : public UiBrowserTest,
std::unique_ptr<content::EyeDropper> eye_dropper_;
};
IN_PROC_BROWSER_TEST_P(EyeDropperBrowserTest, InvokeUi_default) {
// Invokes the eye dropper.
// Flaky: https://crbug.com/1131319
IN_PROC_BROWSER_TEST_P(EyeDropperBrowserTest, DISABLED_InvokeUi_default) {
ShowAndVerifyUi();
}
......
......@@ -1837,8 +1837,7 @@
"--browser-ui-tests-verify-pixels",
"--enable-pixel-output-in-tests",
"--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter",
"--git-revision=${got_revision}",
"--gtest_filter=-*EyeDropperBrowserTest.*"
"--git-revision=${got_revision}"
],
"merge": {
"args": [],
......
......@@ -2208,12 +2208,6 @@
},
'pixel_browser_tests': {
'modifications': {
# TODO(crbug.com/1131319): Re-enable the tests.
'Win10 Tests x64':{
'args': [
'--gtest_filter=-*EyeDropperBrowserTest.*',
],
},
'win-pixel-tester-rel': {
'non_precommit_args': [
# Do not allow retry or it will break the bulk approval process.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment