Commit 363750d1 authored by vasilii's avatar vasilii Committed by Commit bot

Check for NULL PasswordFormManager* in ManagePasswordsUIController::SavePasswordInternal().

BUG=468474

Review URL: https://codereview.chromium.org/1019943002

Cr-Commit-Position: refs/heads/master@{#321408}
parent 96355a91
...@@ -218,8 +218,11 @@ void ManagePasswordsUIController::ChooseCredential( ...@@ -218,8 +218,11 @@ void ManagePasswordsUIController::ChooseCredential(
void ManagePasswordsUIController::SavePasswordInternal() { void ManagePasswordsUIController::SavePasswordInternal() {
password_manager::PasswordFormManager* form_manager = password_manager::PasswordFormManager* form_manager =
passwords_data_.form_manager(); passwords_data_.form_manager();
DCHECK(form_manager); // TODO(vasilii): it's not OK to call SavePassword() when |form_manager| is 0.
form_manager->Save(); // If this is a cause of http://crbug.com/468474 then we should hide the
// bubble when ManagePasswordsUIController changes its internal state.
if (form_manager)
form_manager->Save();
} }
void ManagePasswordsUIController::NeverSavePassword() { void ManagePasswordsUIController::NeverSavePassword() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment