Commit 374813d9 authored by Miyoung Shin's avatar Miyoung Shin Committed by Commit Bot

Change short to int16_t/float, int to uint8_t in third_party/blink/*

- short -> int16_t except layout_theme_mac.mm.
- int -> uint8_t, short -> float in layout_theme_mac.mm.
- Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types

Bug: 929985
Change-Id: I2d8beb79720350f14c99f82a8d53acdd5833e99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501773Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637914}
parent 4fe8a40e
...@@ -87,8 +87,8 @@ struct WebFontDescription { ...@@ -87,8 +87,8 @@ struct WebFontDescription {
Weight weight; Weight weight;
Smoothing smoothing; Smoothing smoothing;
short letter_spacing; int16_t letter_spacing;
short word_spacing; int16_t word_spacing;
#if INSIDE_BLINK #if INSIDE_BLINK
BLINK_PLATFORM_EXPORT WebFontDescription(const FontDescription&); BLINK_PLATFORM_EXPORT WebFontDescription(const FontDescription&);
......
...@@ -130,8 +130,8 @@ bool GetNumericType(const Dictionary& dictionary, ...@@ -130,8 +130,8 @@ bool GetNumericType(const Dictionary& dictionary,
template <> template <>
bool DictionaryHelper::Get(const Dictionary& dictionary, bool DictionaryHelper::Get(const Dictionary& dictionary,
const StringView& key, const StringView& key,
short& value) { int16_t& value) {
return GetNumericType<short>(dictionary, key, value); return GetNumericType<int16_t>(dictionary, key, value);
} }
template <> template <>
......
...@@ -793,11 +793,11 @@ void LayoutThemeMac::SetSearchFieldSize(ComputedStyle& style) const { ...@@ -793,11 +793,11 @@ void LayoutThemeMac::SetSearchFieldSize(ComputedStyle& style) const {
SetSizeFromFont(style, SearchFieldSizes()); SetSizeFromFont(style, SearchFieldSizes());
} }
const int kSearchFieldBorderWidth = 2; const uint8_t kSearchFieldBorderWidth = 2;
void LayoutThemeMac::AdjustSearchFieldStyle(ComputedStyle& style) const { void LayoutThemeMac::AdjustSearchFieldStyle(ComputedStyle& style) const {
// Override border. // Override border.
style.ResetBorder(); style.ResetBorder();
const short border_width = kSearchFieldBorderWidth * style.EffectiveZoom(); const float border_width = kSearchFieldBorderWidth * style.EffectiveZoom();
style.SetBorderLeftWidth(border_width); style.SetBorderLeftWidth(border_width);
style.SetBorderLeftStyle(EBorderStyle::kInset); style.SetBorderLeftStyle(EBorderStyle::kInset);
style.SetBorderRightWidth(border_width); style.SetBorderRightWidth(border_width);
......
...@@ -74,7 +74,7 @@ class MODULES_EXPORT EventSource final ...@@ -74,7 +74,7 @@ class MODULES_EXPORT EventSource final
String url() const; String url() const;
bool withCredentials() const; bool withCredentials() const;
enum State : short { kConnecting = 0, kOpen = 1, kClosed = 2 }; enum State : int16_t { kConnecting = 0, kOpen = 1, kClosed = 2 };
State readyState() const; State readyState() const;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment