Commit 38715b2a authored by Ned Nguyen's avatar Ned Nguyen Committed by Commit Bot

Remove experimental.startup.android.coldish benchmark scheduling code

BUG:760498

This also reshard android_nexus5x_fyi_4_shard_map.json which may cause shifting data of heap_profiling.mobile.disabled benchmark

TBR=pasko@chromium.org

Change-Id: I561d9fbd628b2f53f6e043b524b93c32b03c56d1
Reviewed-on: https://chromium-review.googlesource.com/c/1265129
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#597353}
parent cb4bc5c9
...@@ -14,7 +14,7 @@ Here is the list of benchmarks which we recommend: ...@@ -14,7 +14,7 @@ Here is the list of benchmarks which we recommend:
Android: Android:
* system_health.common_mobile * system_health.common_mobile
* system_health.memory_mobile * system_health.memory_mobile
* experimental.startup.android.coldish * startup.mobile
Desktop: Desktop:
* system_health.common_desktop * system_health.common_desktop
......
...@@ -7,11 +7,6 @@ import urllib ...@@ -7,11 +7,6 @@ import urllib
from core import benchmark_finders from core import benchmark_finders
UNSCHEDULED_TELEMETRY_BENCHMARKS = set([
'experimental.startup.android.coldish'
])
_SHARD_MAP_DIR = os.path.join(os.path.dirname(__file__), 'shard_maps') _SHARD_MAP_DIR = os.path.join(os.path.dirname(__file__), 'shard_maps')
...@@ -20,8 +15,7 @@ _ALL_TELEMETRY_BENCHMARKS_BY_NAMES= dict( ...@@ -20,8 +15,7 @@ _ALL_TELEMETRY_BENCHMARKS_BY_NAMES= dict(
_ALL_PERF_WATERFALL_TELEMETRY_BENCHMARKS = frozenset( _ALL_PERF_WATERFALL_TELEMETRY_BENCHMARKS = frozenset(
s for s in benchmark_finders.GetAllPerfBenchmarks() if s.Name() not in benchmark_finders.GetAllPerfBenchmarks())
UNSCHEDULED_TELEMETRY_BENCHMARKS)
_ANDROID_GO_BENCHMARK_NAMES = { _ANDROID_GO_BENCHMARK_NAMES = {
......
...@@ -571,7 +571,6 @@ def current_benchmarks(): ...@@ -571,7 +571,6 @@ def current_benchmarks():
for b in discover.DiscoverClasses( for b in discover.DiscoverClasses(
benchmarks_dir, top_level_dir, benchmark_module.Benchmark, benchmarks_dir, top_level_dir, benchmark_module.Benchmark,
index_by_class_name=True).values(): index_by_class_name=True).values():
if not b.Name() in bot_platforms.UNSCHEDULED_TELEMETRY_BENCHMARKS:
all_benchmarks.append(b) all_benchmarks.append(b)
return sorted(all_benchmarks, key=lambda b: b.Name()) return sorted(all_benchmarks, key=lambda b: b.Name())
......
{ {
"0": { "0": {
"benchmarks": { "benchmarks": {
"experimental.startup.android.coldish": {} "heap_profiling.mobile.disabled": {}
} }
}, },
"1": { "1": {
"benchmarks": { "benchmarks": {
"heap_profiling.mobile.disabled": {},
"heap_profiling.mobile.native": {} "heap_profiling.mobile.native": {}
} }
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment